This repository was archived by the owner on Mar 13, 2026. It is now read-only.
Commit 055eba8
committed
bug: don't rollback non-spanner connections on reset
This is the simplest way to address bug #706 and address the
`AttributeError: 'Connection' object has no attribute 'rollback'`
I'm seeing when connections from BigQuery engines get caught by this
event handler.
I think we should be able to rely on SQLAlchemy's [reset on
return](https://docs.sqlalchemy.org/en/20/core/pooling.html#reset-on-return)
behaviour to rollback transactions when they're reset rather than call
rollback ourselves. That behaviour is also something end users can
configure, so it'd be good to respect their settings if they disable
the behaviour.
Fixes: #7061 parent 4a6d965 commit 055eba8
1 file changed
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | | - | |
76 | 74 | | |
77 | 75 | | |
78 | 76 | | |
| |||
0 commit comments