Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Commit b4d878e

Browse files
committed
review comments
1 parent d965bc3 commit b4d878e

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

google/cloud/spanner_v1/client.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,7 @@ class Client(ClientWithProject):
139139
140140
:type default_transaction_options: :class:`~google.cloud.spanner_v1.TransactionOptions`
141141
or :class:`dict`
142-
:param default_transaction_options: (Optional) Client options used to set the default_transaction_options
143-
used for all Read Write Transactions.
142+
:param default_transaction_options: (Optional) Default options to use for all read/write transactions.
144143
145144
:raises: :class:`ValueError <exceptions.ValueError>` if both ``read_only``
146145
and ``admin`` are :data:`True`
@@ -304,7 +303,7 @@ def default_transaction_options(self):
304303
:rtype:
305304
:class:`~google.cloud.spanner_v1.TransactionOptions`
306305
or :class:`dict`
307-
:returns: The default_transaction_options for the client.
306+
:returns: The default transaction options that are used by this client for all read/write transactions.
308307
"""
309308
return self._default_transaction_options
310309

@@ -459,7 +458,6 @@ def default_transaction_options(self, default_transaction_options):
459458
"""Sets default_transaction_options for the client
460459
:type default_transaction_options: :class:`~google.cloud.spanner_v1.TransactionOptions`
461460
or :class:`dict`
462-
:param default_transaction_options: Client options used to set the default_transaction_options
463-
used for all Read Write Transactions.
461+
:param default_transaction_options: Default options to use for all read/write transactions.
464462
"""
465463
self._default_transaction_options = default_transaction_options

google/cloud/spanner_v1/database.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -814,7 +814,7 @@ def batch(
814814
:type isolation_level:
815815
:class:`google.cloud.spanner_v1.types.TransactionOptions.IsolationLevel`
816816
:param isolation_level:
817-
(Optional) Sets isolation level for the transaction and overrides the isolation level set at the client.
817+
(Optional) Sets the isolation level for this transaction. This overrides any default isolation level set for the client.
818818
819819
:rtype: :class:`~google.cloud.spanner_v1.database.BatchCheckout`
820820
:returns: new wrapper
@@ -1236,6 +1236,7 @@ def __exit__(self, exc_type, exc_val, exc_tb):
12361236
max_commit_delay=self._max_commit_delay,
12371237
exclude_txn_from_change_streams=self._exclude_txn_from_change_streams,
12381238
isolation_level=self._isolation_level,
1239+
**self._kw,
12391240
)
12401241
finally:
12411242
if self._database.log_commit_stats and self._batch.commit_stats:

0 commit comments

Comments
 (0)