Adjustments to handle-disabled behaviour of MetricsCapture

Author: lszinv

google/cloud/spanner_v1/metrics/metrics_capture.py

@@ -44,7 +44,8 @@ def __enter__(self):
         SpannerMetricsTracerFactory.current_metrics_tracer = (
             factory.create_metrics_tracer()
         )
-        SpannerMetricsTracerFactory.current_metrics_tracer.record_operation_start()
+        if SpannerMetricsTracerFactory.current_metrics_tracer:
+            SpannerMetricsTracerFactory.current_metrics_tracer.record_operation_start()
         return self
 
     def __exit__(self, exc_type, exc_value, traceback):
@@ -61,5 +62,6 @@ def __exit__(self, exc_type, exc_value, traceback):
         Returns:
             bool: False to propagate the exception if any occurred.
         """
-        SpannerMetricsTracerFactory.current_metrics_tracer.record_operation_completion()
+        if SpannerMetricsTracerFactory.current_metrics_tracer:
+            SpannerMetricsTracerFactory.current_metrics_tracer.record_operation_completion()
         return False  # Propagate the exception if any

google/cloud/spanner_v1/metrics/metrics_tracer_factory.py

@@ -259,6 +259,9 @@ def create_metrics_tracer(self) -> MetricsTracer:
         Returns:
             MetricsTracer: A MetricsTracer instance with default settings and client attributes.
         """
+        if not HAS_OPENTELEMETRY_INSTALLED:
+            return None
+
         metrics_tracer = MetricsTracer(
             enabled=self.enabled and HAS_OPENTELEMETRY_INSTALLED,
             instrument_attempt_latency=self._instrument_attempt_latency,

google/cloud/spanner_v1/metrics/spanner_metrics_tracer_factory.py

@@ -76,6 +76,8 @@ def __new__(
             cls._metrics_tracer_factory = MetricsTracerFactory(
                 enabled, SPANNER_SERVICE_NAME
             )
+            if not HAS_OPENTELEMETRY_INSTALLED:
+                return cls._metrics_tracer_factory
 
             client_uid = cls._generate_client_uid()
             cls._metrics_tracer_factory.set_client_uid(client_uid)