Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore: edition sample fix with increased timeout #1339

Merged
harshachinta merged 1 commit into from
Apr 22, 2025
Merged

chore: edition sample fix with increased timeout #1339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/samples/snippets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,13 @@ def update_instance(instance_id):
labels={
"sample_name": "snippets-update_instance-explicit",
},
edition=spanner_instance_admin.Instance.Edition.STANDARD, # Optional
edition=spanner_instance_admin.Instance.Edition.ENTERPRISE, # Optional
Copy link
Copy Markdown
Contributor Author

@harshachinta harshachinta Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to merge split API sample I had to change this to STANDARD in that PR so that the tests pass.
Reverting back that change in this PR.

),
field_mask=field_mask_pb2.FieldMask(paths=["labels", "edition"]),
)

print("Waiting for operation to complete...")
operation.result(OPERATION_TIMEOUT_SECONDS)
operation.result(900)
Copy link
Copy Markdown
Contributor Author

@harshachinta harshachinta Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current timeout of 240 seconds, the sample is failing. When we increase it to 900 seconds it works.
Raised the issue to the editions team. Meanwhile to unblock PR merges and prevent samples failure this PR will help.

Copy link
Copy Markdown
Contributor Author

@harshachinta harshachinta Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with editions team that is expected behaviour.

Yes, this is expected. Previously we weren't waiting for galaxy and spanfe caches to be populated with the modified edition. Now we are. This takes approximately 10 min.


print("Updated instance {}".format(instance_id))

Expand Down
Loading