This repository was archived by the owner on Mar 31, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 104
feat(spanner): add Client Context support to options #1499
Merged
olavloite
merged 12 commits into
googleapis:main
from
aseering:feat/client-context-support
Mar 3, 2026
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8ea7d84
feat(spanner): add ClientContext support to options
aseering 55b213b
Merge branch 'main' into feat/client-context-support
aseering 869c252
feat: Propagate client_context in Session and update tests
aseering 3611aec
fix: Resolve race condition in concurrent Transaction initialization
aseering d249c67
fix: Secure ClientContext merging and improve type safety
aseering aca8616
Merge remote-tracking branch 'origin/main' into feat/client-context-s…
aseering 5fe5319
chore: remove unused code
olavloite c301cbc
Move race-condition fix to a separate branch
aseering 424223d
test: remove thread-unsafe assertions for concurrent tests
olavloite 35dba42
chore: move ClientContext validation to a helper function
olavloite 95a9549
Merge remote-tracking branch 'remote/main' into feat/client-context-s…
aseering 2ffcdf4
fix: remove unused ClientContext imports to pass flake8 lint
aseering File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block of code for validating and converting
client_contextis duplicated in several places (e.g.,_BatchBase,MutationGroups,Client,_SnapshotBase). To improve maintainability and reduce code duplication, consider extracting this logic into a helper function ingoogle/cloud/spanner_v1/_helpers.py.