resolve comments

Author: Pulkit0110

google/cloud/storage/asyncio/async_grpc_client.py

@@ -215,7 +215,7 @@ async def get_object(
             if_generation_not_match=if_generation_not_match,
             if_metageneration_match=if_metageneration_match,
             if_metageneration_not_match=if_metageneration_not_match,
-            soft_deleted=soft_deleted if soft_deleted is not None else False,
+            soft_deleted=soft_deleted or False,
             **kwargs,
         )
 

tests/system/test_zonal.py

@@ -601,3 +601,56 @@ async def _run():
         gc.collect()
 
     event_loop.run_until_complete(_run())
+
+def test_get_object_after_appendable_write(
+    grpc_clients,
+    grpc_client_direct,
+    event_loop,
+    storage_client,
+    blobs_to_delete,
+):
+    """Test getting object metadata after writing with AsyncAppendableObjectWriter.
+
+    This test:
+    1. Creates a test object using AsyncAppendableObjectWriter
+    2. Appends content to the object (without finalizing)
+    3. Closes the write stream
+    4. Fetches the object metadata using AsyncGrpcClient.get_object()
+    5. Verifies the object size matches the written data
+    """
+
+    async def _run():
+        grpc_client = grpc_client_direct
+        object_name = f"test-get-object-{uuid.uuid4().hex}"
+        test_data = b"Some test data bytes."
+        expected_size = len(test_data)
+
+        writer = AsyncAppendableObjectWriter(
+            grpc_client,
+            _ZONAL_BUCKET,
+            object_name,
+        )
+
+        await writer.open()
+        await writer.append(test_data)
+        await writer.close(finalize_on_close=False)
+
+        obj = await grpc_client.get_object(
+            bucket_name=_ZONAL_BUCKET,
+            object_name=object_name,
+        )
+
+        # Assert
+        assert obj is not None
+        assert obj.name == object_name
+        assert obj.bucket == f"projects/_/buckets/{_ZONAL_BUCKET}"
+        assert obj.size == expected_size, (
+            f"Expected object size {expected_size}, got {obj.size}"
+        )
+
+        # Cleanup
+        blobs_to_delete.append(storage_client.bucket(_ZONAL_BUCKET).blob(object_name))
+        del writer
+        gc.collect()
+
+    event_loop.run_until_complete(_run())

tests/unit/asyncio/test_async_grpc_client.py

@@ -254,6 +254,7 @@ async def test_delete_object(self, mock_async_storage_client):
         assert request.if_generation_not_match == if_generation_not_match
         assert request.if_metageneration_match == if_metageneration_match
         assert request.if_metageneration_not_match == if_metageneration_not_match
+        assert request.soft_deleted is False
 
     @mock.patch("google.cloud._storage_v2.StorageAsyncClient")
     @pytest.mark.asyncio