Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,11 @@ async def finalize(self) -> _storage_v2.Object:
self.offset = None
return self.object_resource

@property
def is_stream_open(self) -> bool:
return self._is_stream_open


# helper methods.
async def append_from_string(self, data: str):
"""
Expand Down
12 changes: 6 additions & 6 deletions tests/unit/asyncio/test_async_appendable_object_writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def test_init(mock_write_object_stream, mock_client):
assert writer.object_name == OBJECT
assert writer.generation is None
assert writer.write_handle is None
assert not writer._is_stream_open
assert not writer.is_stream_open
assert writer.offset is None
assert writer.persisted_size is None
assert writer.bytes_appended_since_last_flush == 0
Expand Down Expand Up @@ -225,7 +225,7 @@ async def test_open_appendable_object_writer(mock_write_object_stream, mock_clie

# Assert
mock_stream.open.assert_awaited_once()
assert writer._is_stream_open
assert writer.is_stream_open
assert writer.generation == GENERATION
assert writer.write_handle == WRITE_HANDLE
assert writer.persisted_size == 0
Expand Down Expand Up @@ -255,7 +255,7 @@ async def test_open_appendable_object_writer_existing_object(

# Assert
mock_stream.open.assert_awaited_once()
assert writer._is_stream_open
assert writer.is_stream_open
assert writer.generation == GENERATION
assert writer.write_handle == WRITE_HANDLE
assert writer.persisted_size == PERSISTED_SIZE
Expand Down Expand Up @@ -379,7 +379,7 @@ async def test_close(mock_write_object_stream, mock_client):
mock_stream.close.assert_awaited_once()
assert writer.offset is None
assert persisted_size == 1024
assert not writer._is_stream_open
assert not writer.is_stream_open


@pytest.mark.asyncio
Expand Down Expand Up @@ -415,7 +415,7 @@ async def test_finalize_on_close(mock_write_object_stream, mock_client):

# Assert
mock_stream.close.assert_awaited_once()
assert not writer._is_stream_open
assert not writer.is_stream_open
assert writer.offset is None
assert writer.object_resource == mock_resource
assert writer.persisted_size == 2048
Expand Down Expand Up @@ -448,7 +448,7 @@ async def test_finalize(mock_write_object_stream, mock_client):
assert writer.object_resource == mock_resource
assert writer.persisted_size == 123
assert gcs_object == mock_resource
assert writer._is_stream_open is False
assert writer.is_stream_open is False
Comment thread
chandra-siri marked this conversation as resolved.
Outdated
assert writer.offset is None


Expand Down