Skip to content

feat: update librarian.yaml for Node#2775

Open
jskeet wants to merge 1 commit into
googleapis:mainfrom
jskeet:librarian-node
Open

feat: update librarian.yaml for Node#2775
jskeet wants to merge 1 commit into
googleapis:mainfrom
jskeet:librarian-node

Conversation

@jskeet
Copy link
Copy Markdown

@jskeet jskeet commented May 12, 2026

This introduces a new Node strategy specifically for https://github.com/googleapis/google-cloud-node, with an updater which is aware of the expected Librarian format for Node.

Once Librarian has moved off release-please, the strategy and updater can be removed.

Towards googleapis/librarian#5461

@jskeet jskeet requested a review from chingor13 May 12, 2026 12:04
@jskeet jskeet requested review from a team as code owners May 12, 2026 12:04
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label May 12, 2026
@jskeet
Copy link
Copy Markdown
Author

jskeet commented May 12, 2026

(This was largely copied from #2750...)

@jskeet jskeet force-pushed the librarian-node branch 6 times, most recently from b246950 to 4d955b3 Compare May 12, 2026 13:32
This introduces a new Node strategy specifically for
https://github.com/googleapis/google-cloud-node, with an updater which
is aware of the expected Librarian format for Node.

Once Librarian has moved off release-please, the strategy and updater
can be removed.

Towards googleapis/librarian#5461
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a new strategy? If the librarian.yaml file doesn't exist on other yoshi-node repos, then it's a no-op.

Can we add it to the existing strategy?

@chingor13
Copy link
Copy Markdown
Contributor

Does this need to be a new strategy? If the librarian.yaml file doesn't exist on other yoshi-node repos, then it's a no-op.

Can we add it to the existing strategy?

Oh, I see, there is no yoshi-node strategy -- only the default node one.

Copy link
Copy Markdown
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add to the factory so that it can build the strategy you've written. https://github.com/googleapis/release-please/blob/main/src/factory.ts

@jskeet
Copy link
Copy Markdown
Author

jskeet commented May 15, 2026

Yup - no Yoshi one, and you never know whether another Node repo may have a librarian.yaml file of an entirely different nature. Also, once google-cloud-node moves off release-please, it would be good to just revert this change :)

All that said, I have little experience with release-please, so I'm happy to go in whatever direction you suggest.

@jskeet
Copy link
Copy Markdown
Author

jskeet commented May 15, 2026

You'll need to add to the factory so that it can build the strategy you've written. https://github.com/googleapis/release-please/blob/main/src/factory.ts

Thanks, will do that on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants