feat: update librarian.yaml for Node#2775
Conversation
|
(This was largely copied from #2750...) |
b246950 to
4d955b3
Compare
This introduces a new Node strategy specifically for https://github.com/googleapis/google-cloud-node, with an updater which is aware of the expected Librarian format for Node. Once Librarian has moved off release-please, the strategy and updater can be removed. Towards googleapis/librarian#5461
chingor13
left a comment
There was a problem hiding this comment.
Does this need to be a new strategy? If the librarian.yaml file doesn't exist on other yoshi-node repos, then it's a no-op.
Can we add it to the existing strategy?
Oh, I see, there is no yoshi-node strategy -- only the default node one. |
chingor13
left a comment
There was a problem hiding this comment.
You'll need to add to the factory so that it can build the strategy you've written. https://github.com/googleapis/release-please/blob/main/src/factory.ts
|
Yup - no Yoshi one, and you never know whether another Node repo may have a librarian.yaml file of an entirely different nature. Also, once google-cloud-node moves off release-please, it would be good to just revert this change :) All that said, I have little experience with release-please, so I'm happy to go in whatever direction you suggest. |
Thanks, will do that on Monday. |
This introduces a new Node strategy specifically for https://github.com/googleapis/google-cloud-node, with an updater which is aware of the expected Librarian format for Node.
Once Librarian has moved off release-please, the strategy and updater can be removed.
Towards googleapis/librarian#5461