Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

Commit 1aac2f9

Browse files
authored
chore: avoid using implicitly declared samples target in BUILD.bazel (#994)
* chore: avoid using implictly declared target Now to include samples in the package we have to pass includeSamples = True in the build file such as: java_gapic_assembly_gradle_pkg( name = "google-cloud-accessapproval-v1-java", deps = [ ":accessapproval_java_gapic", ":accessapproval_java_grpc", ":accessapproval_java_proto", ":accessapproval_proto", ], includeSamples = True, ) * use snake case
1 parent 4673e52 commit 1aac2f9

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

rules_java_gapic/java_gapic_pkg.bzl

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ java_gapic_srcs_pkg = rule(
317317
def java_gapic_assembly_gradle_pkg(
318318
name,
319319
deps,
320+
include_samples = False,
320321
assembly_name = None,
321322
transport = None,
322323
**kwargs):
@@ -341,9 +342,9 @@ def java_gapic_assembly_gradle_pkg(
341342
processed_deps = {} #there is no proper Set in Starlark
342343
for dep in deps:
343344
# Use contains instead of endswith since microgenerator testing may use differently-named targets.
344-
if "samples" in dep:
345-
samples.append(dep)
346-
elif "_java_gapic" in dep:
345+
if "_java_gapic" in dep:
346+
if include_samples:
347+
samples.append(dep + "_samples")
347348
_put_dep_in_a_bucket(dep, client_deps, processed_deps)
348349
_put_dep_in_a_bucket("%s_test" % dep, client_test_deps, processed_deps)
349350
_put_dep_in_a_bucket("%s_resource_name" % dep, proto_deps, processed_deps)

0 commit comments

Comments
 (0)