Skip to content

Commit 427877e

Browse files
committed
fix: rename tests.
1 parent 1440456 commit 427877e

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

gax-java/gax/src/test/java/com/google/api/gax/tracing/GoldenSignalsMetricsTracerFactoryTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ void setUp() {
4848
}
4949

5050
@Test
51-
void newTracer_createsTracer_successfully() {
51+
void newTracerWithSpanName_shouldCreateTracer_ifMetricsRecorderIsNotNull() {
5252
tracerFactory.withContext(ApiTracerContext.empty());
5353
ApiTracer actual =
5454
tracerFactory.newTracer(
@@ -57,15 +57,15 @@ void newTracer_createsTracer_successfully() {
5757
}
5858

5959
@Test
60-
void newTracer_createsBaseTracer_ifMetricsRecorderIsNull() {
60+
void newTracerWithSpanName_shouldCreateBaseTracer_ifMetricsRecorderIsNull() {
6161
ApiTracer actual =
6262
tracerFactory.newTracer(
6363
mock(ApiTracer.class), mock(SpanName.class), ApiTracerFactory.OperationType.Unary);
6464
assertThat(actual).isInstanceOf(BaseApiTracer.class);
6565
}
6666

6767
@Test
68-
void newTracer_shouldMergeApiTracerContext() {
68+
void newTracerWithApiTracerContext_shouldMergeApiTracerContext() {
6969
ApiTracerContext clientLevelTracerContext = mock(ApiTracerContext.class, RETURNS_DEEP_STUBS);
7070
ApiTracerContext methodLevelTracerContext = mock(ApiTracerContext.class);
7171
when(clientLevelTracerContext.libraryMetadata().artifactName()).thenReturn("does not matter");
@@ -79,7 +79,7 @@ void newTracer_shouldMergeApiTracerContext() {
7979
}
8080

8181
@Test
82-
void newTracer1_createsBaseTracer_ifMetricsRecorderIsNull() {
82+
void newTracerWithApiTracerContext_shouldCreateBaseTracer_ifMetricsRecorderIsNull() {
8383
ApiTracer actual = tracerFactory.newTracer(mock(ApiTracer.class), mock(ApiTracerContext.class));
8484

8585
assertThat(actual).isInstanceOf(BaseApiTracer.class);

0 commit comments

Comments
 (0)