fix: address code quality issues

Author: diegomarquezp

gax-java/gax/src/main/java/com/google/api/gax/tracing/SpanTracerFactory.java

@@ -73,8 +73,7 @@ public ApiTracer newTracer(ApiTracer parent, SpanName spanName, OperationType op
     // feature is developed.
     String attemptSpanName = spanName.getClientName() + "/" + spanName.getMethodName() + "/attempt";
 
-    SpanTracer spanTracer = new SpanTracer(tracer, this.apiTracerContext, attemptSpanName);
-    return spanTracer;
+    return new SpanTracer(tracer, this.apiTracerContext, attemptSpanName);
   }
 
   @Override

gax-java/gax/src/test/java/com/google/api/gax/tracing/SpanTracerFactoryTest.java

@@ -33,7 +33,6 @@
 import static com.google.common.truth.Truth.assertThat;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.anyString;
-import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.atLeastOnce;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
@@ -209,7 +208,7 @@ void testNewTracer_withContext_grpc_usesFullMethodName() {
 
     tracerInstance.attemptStarted(null, 1);
 
-    verify(tracer).spanBuilder(eq("google.cloud.v1.Service/Method"));
+    verify(tracer).spanBuilder("google.cloud.v1.Service/Method");
   }
 
   @ParameterizedTest
@@ -235,7 +234,7 @@ void testNewTracer_withContext_http_usesHttpMethodAndPathTemplate(
 
     tracerInstance.attemptStarted(null, 1);
 
-    verify(tracer).spanBuilder(eq(expectedSpanName));
+    verify(tracer).spanBuilder(expectedSpanName);
   }
 
   @Test
@@ -252,7 +251,7 @@ void testNewTracer_withContext_http_noHttpMethodOrPathTemplate_usesFullMethodNam
 
     tracerInstance.attemptStarted(null, 1);
 
-    verify(tracer).spanBuilder(eq("google.cloud.v1.Service.Method"));
+    verify(tracer).spanBuilder("google.cloud.v1.Service.Method");
   }
 
   @Test
@@ -263,7 +262,7 @@ void testNewTracer_withSpanName_usesPlaceholder() {
 
     tracerInstance.attemptStarted(null, 1);
 
-    verify(tracer).spanBuilder(eq("Service/Method/attempt"));
+    verify(tracer).spanBuilder("Service/Method/attempt");
   }
 
   @Test

gax-java/gax/src/test/java/com/google/api/gax/tracing/SpanTracerTest.java

@@ -32,7 +32,6 @@
 import static com.google.common.truth.Truth.assertThat;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.anyString;
-import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
@@ -70,8 +69,8 @@ void testAttemptLifecycle_startsAndEndsAttemptSpan() {
     spanTracer.attemptStarted(new Object(), 1);
     spanTracer.attemptSucceeded();
 
-    verify(tracer).spanBuilder(eq(ATTEMPT_SPAN_NAME));
-    verify(spanBuilder).setSpanKind(eq(SpanKind.CLIENT));
+    verify(tracer).spanBuilder(ATTEMPT_SPAN_NAME);
+    verify(spanBuilder).setSpanKind(SpanKind.CLIENT);
     verify(span).end();
   }