chore: reduce showcase version duplication in source (#1864)

* chore: reduce showcase version duplication in source

* chore: install modules before parsing showcase version

Author: burkedavison

.github/workflows/ci.yaml

@@ -4,8 +4,6 @@ on:
       - main
   pull_request:
 name: ci
-env:
-  SHOWCASE_VERSION: 0.28.2
 jobs:
   build:
     runs-on: ubuntu-22.04
@@ -190,12 +188,14 @@ jobs:
             -P enable-golden-tests \
             --batch-mode \
             --no-transfer-progress
-
+      - name: Parse showcase version
+        working-directory: showcase/gapic-showcase
+        run: echo "SHOWCASE_VERSION=$(mvn help:evaluate -Dexpression=gapic-showcase.version -q -DforceStdout)" >> "$GITHUB_ENV"
       - name: Install showcase server
         run: |
           sudo mkdir -p /usr/src/showcase
           sudo chown -R ${USER} /usr/src/
-          curl --location https://github.com/googleapis/gapic-showcase/releases/download/v${SHOWCASE_VERSION}/gapic-showcase-${SHOWCASE_VERSION}-linux-amd64.tar.gz --output /usr/src/showcase/showcase-${SHOWCASE_VERSION}-linux-amd64.tar.gz
+          curl --location https://github.com/googleapis/gapic-showcase/releases/download/v${{env.SHOWCASE_VERSION}}/gapic-showcase-${{env.SHOWCASE_VERSION}}-linux-amd64.tar.gz --output /usr/src/showcase/showcase-${{env.SHOWCASE_VERSION}}-linux-amd64.tar.gz
           cd /usr/src/showcase/
           tar -xf showcase-*
           ./gapic-showcase run &
@@ -222,11 +222,14 @@ jobs:
       - run: native-image --version
       - name: Install sdk-platform-java
         run: mvn install -B -ntp -DskipTests -Dclirr.skip -Dcheckstyle.skip
+      - name: Parse showcase version
+        working-directory: showcase/gapic-showcase
+        run: echo "SHOWCASE_VERSION=$(mvn help:evaluate -Dexpression=gapic-showcase.version -q -DforceStdout)" >> "$GITHUB_ENV"
       - name: Install showcase server
         run: |
           sudo mkdir -p /usr/src/showcase
           sudo chown -R ${USER} /usr/src/
-          curl --location https://github.com/googleapis/gapic-showcase/releases/download/v${SHOWCASE_VERSION}/gapic-showcase-${SHOWCASE_VERSION}-linux-amd64.tar.gz --output /usr/src/showcase/showcase-${SHOWCASE_VERSION}-linux-amd64.tar.gz
+          curl --location https://github.com/googleapis/gapic-showcase/releases/download/v${{env.SHOWCASE_VERSION}}/gapic-showcase-${{env.SHOWCASE_VERSION}}-linux-amd64.tar.gz --output /usr/src/showcase/showcase-${{env.SHOWCASE_VERSION}}-linux-amd64.tar.gz
           cd /usr/src/showcase/
           tar -xf showcase-*
           ./gapic-showcase run &

.github/workflows/sonar.yaml

@@ -1,6 +1,4 @@
 name: SonarCloud Build
-env:
-  SHOWCASE_VERSION: 0.28.2
 on:
   push:
     branches:
@@ -32,11 +30,19 @@ jobs:
           path: ~/.m2
           key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
           restore-keys: ${{ runner.os }}-m2
+      - name: Install modules to local maven
+        run: |
+          mvn install -T 1C -DskipTests -ntp -B
+          cd showcase
+          mvn install -T 1C -DskipTests -ntp -B
+      - name: Parse showcase version
+        working-directory: showcase/gapic-showcase
+        run: echo "SHOWCASE_VERSION=$(mvn help:evaluate -Dexpression=gapic-showcase.version -q -DforceStdout)" >> "$GITHUB_ENV"
       - name: Install showcase server
         run: |
             sudo mkdir -p /usr/src/showcase
             sudo chown -R ${USER} /usr/src/
-            curl --location https://github.com/googleapis/gapic-showcase/releases/download/v${SHOWCASE_VERSION}/gapic-showcase-${SHOWCASE_VERSION}-linux-amd64.tar.gz --output /usr/src/showcase/showcase-${SHOWCASE_VERSION}-linux-amd64.tar.gz
+            curl --location https://github.com/googleapis/gapic-showcase/releases/download/v${{env.SHOWCASE_VERSION}}/gapic-showcase-${{env.SHOWCASE_VERSION}}-linux-amd64.tar.gz --output /usr/src/showcase/showcase-${{env.SHOWCASE_VERSION}}-linux-amd64.tar.gz
             cd /usr/src/showcase/
             tar -xf showcase-*
             ./gapic-showcase run &

.kokoro/presubmit/downstream-build.sh

@@ -15,8 +15,6 @@
 
 set -eo pipefail
 
-SHOWCASE_VERSION=0.28.2
-
 ## Get the directory of the build script
 scriptDir=$(realpath "$(dirname "${BASH_SOURCE[0]}")")
 ## cd to the parent directory, i.e. the root of the git repo
@@ -64,16 +62,19 @@ popd
 
 ### Round 3
 # Run showcase tests in GraalVM
+pushd showcase/gapic-showcase
+SHOWCASE_VERSION=$(mvn help:evaluate -Dexpression=gapic-showcase.version -q -DforceStdout)
+popd
 
 # Start showcase server
 mkdir -p /usr/src/showcase
 curl --location https://github.com/googleapis/gapic-showcase/releases/download/v"${SHOWCASE_VERSION}"/gapic-showcase-"${SHOWCASE_VERSION}"-linux-amd64.tar.gz --output /usr/src/showcase/showcase-"${SHOWCASE_VERSION}"-linux-amd64.tar.gz
 pushd /usr/src/showcase/
 tar -xf showcase-*
 ./gapic-showcase run &
+popd
 
 # Run showcase tests with `native` profile
-popd
 pushd showcase
 mvn test -Pnative,-showcase -Denforcer.skip=true -ntp -B
 popd

showcase/README.md

@@ -16,10 +16,10 @@ versions is not guaranteed. If changing the version of the server, it may also b
 update to a compatible client version in `./WORKSPACE`.
 
 ```shell
-$ GAPIC_SHOWCASE_VERSION=0.28.2
-$ go install github.com/googleapis/gapic-showcase/cmd/gapic-showcase@v"$GAPIC_SHOWCASE_VERSION"
-$ PATH=$PATH:`go env GOPATH`/bin
-$ gapic-showcase --help
+# Install the showcase server version defined in gapic-showcase/pom.xml
+showcase/ $ go install github.com/googleapis/gapic-showcase/cmd/gapic-showcase@v"$(cd gapic-showcase;mvn help:evaluate -Dexpression=gapic-showcase.version -q -DforceStdout)"
+showcase/ $ PATH=$PATH:`go env GOPATH`/bin
+showcase/ $ gapic-showcase --help
 > Root command of gapic-showcase
 > 
 > Usage: