Skip to content

Commit 713523b

Browse files
committed
chore: Update the scripts
1 parent ba9bb67 commit 713523b

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

.github/scripts/test_dependency_compatibility.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# upper-bounds dependency file at the root of the repo.
1010
# There are two potential inputs to the script:
1111
# 1. -f {file}: Custom file/path for the upper-bound dependencies to test
12-
# 2. -l {deps_list}: Comma-separated list of dependencies to test (e.g. protobuf=4.31.0,guava=33.4.8-jre)
12+
# 2. -l {deps_list}: Comma-separated list of dependencies to test (e.g. protobuf:4.31.0,guava:33.4.8-jre)
1313
# Note: Do not include the `-D` prefix or `.version` suffix. Those values will be appended when generating
1414
# the maven command.
1515
#
@@ -18,15 +18,14 @@
1818
# an input for the deps_list to manually run a subset of dependencies.
1919
#
2020
# The default upper-bound dependencies file is `dependencies.txt` located in the root
21-
# of sdk-platform-java. The upper-bound dependencies file will be in the format of:
22-
# {groupId}:{artifactId}={version} or {artifactId}={version}
21+
# of sdk-platform-java. See the upper-bound dependencies file for the dependency format.
2322

2423
set -ex
2524

2625
function print_help() {
2726
echo "Unexpected input argument for this script."
2827
echo "Use -f {file} for the directory of the upper-bound dependencies file."
29-
echo "Use -l {deps_list} for a comma-separated list of dependencies to test (Format: dep1=1.0,dep2=2.0)"
28+
echo "Use -l {deps_list} for a comma-separated list of dependencies to test (Format: dep1:1.0,dep2:2.0)"
3029
}
3130

3231
# Default to the upper bounds file in the root of the repo

.github/workflows/dependency_compatibility_test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
run: echo "DEPENDENCIES_LIST=${{ github.event.inputs.dependencies-list }}" >> $GITHUB_ENV
3636

3737
# Run in the root module which should test for everything except for showcase
38-
- name: Perform Dependency Compatibility Testing
38+
- name: Perform Dependency Compatibility Unit Testing
3939
shell: bash
4040
run: |
4141
if [[ -n "${{ env.DEPENDENCIES_LIST }}" ]]; then
@@ -64,7 +64,7 @@ jobs:
6464
cd -
6565
6666
# Run Showcase's Integration Tests
67-
- name: Perform Dependency Compatibility Testing (Showcase only)
67+
- name: Perform Dependency Compatibility Integration Testing (Showcase Tests)
6868
shell: bash
6969
# Need to cd out of the directory to get the scripts as this step is run inside the java-showcase directory
7070
run: |

0 commit comments

Comments
 (0)