Skip to content

Commit 741cb2c

Browse files
committed
fix(gax): make isLoggingEnabled and setLoggingEnabled package private
1 parent ed367ec commit 741cb2c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

gax-java/gax/src/main/java/com/google/api/gax/logging/LoggingUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ public static void logActionableError(
179179
LoggerProvider loggerProvider,
180180
org.slf4j.event.Level level,
181181
String message) {
182-
if (loggingV2Enabled) {
182+
if (loggingEnabled) {
183183
org.slf4j.Logger logger = loggerProvider.getLogger();
184184
Slf4jUtils.log(logger, level, logContext, message);
185185
}

gax-java/gax/src/test/java/com/google/api/gax/logging/LoggingUtilsTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,11 @@ void tearDown() {
9494

9595
@Test
9696
void testLogActionableError_loggingDisabled() {
97-
LoggingUtils.setLoggingV2Enabled(false);
97+
LoggingUtils.setLoggingEnabled(false);
9898
LoggerProvider loggerProvider = mock(LoggerProvider.class);
9999

100100
LoggingUtils.logActionableError(
101-
Collections.emptyMap(), loggerProvider, org.slf4j.event.Level.INFO, "message");
101+
Collections.emptyMap(), loggerProvider, org.slf4j.event.Level.DEBUG, "message");
102102

103103
verify(loggerProvider, never()).getLogger();
104104
}
@@ -120,3 +120,4 @@ void testLogActionableError_success() {
120120
verify(loggerProvider).getLogger();
121121
}
122122
}
123+

0 commit comments

Comments
 (0)