Skip to content

Commit 8cd6296

Browse files
committed
fix: remove unused getSpanName and visibility comment
1 parent c480376 commit 8cd6296

2 files changed

Lines changed: 0 additions & 8 deletions

File tree

gax-java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonCallableFactory.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
import com.google.api.gax.rpc.UnaryCallSettings;
4646
import com.google.api.gax.rpc.UnaryCallable;
4747
import com.google.api.gax.tracing.ApiTracerContext;
48-
import com.google.api.gax.tracing.SpanName;
4948
import com.google.api.gax.tracing.TracedUnaryCallable;
5049
import javax.annotation.Nonnull;
5150

@@ -222,11 +221,6 @@ ServerStreamingCallable<RequestT, ResponseT> createServerStreamingCallable(
222221
return callable.withDefaultCallContext(clientContext.getDefaultCallContext());
223222
}
224223

225-
@InternalApi("Visible for testing")
226-
static SpanName getSpanName(@Nonnull ApiMethodDescriptor<?, ?> methodDescriptor) {
227-
return SpanName.of(getApiTracerContext(methodDescriptor));
228-
}
229-
230224
static ApiTracerContext getApiTracerContext(@Nonnull ApiMethodDescriptor<?, ?> methodDescriptor) {
231225
return ApiTracerContext.newBuilder()
232226
.setFullMethodName(methodDescriptor.getFullMethodName())

gax-java/gax/src/main/java/com/google/api/gax/tracing/ObservabilityAttributes.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,4 @@ public class ObservabilityAttributes {
8686
public static final String URL_TEMPLATE_ATTRIBUTE = "url.template";
8787

8888
public static final String DESTINATION_RESOURCE_ID_ATTRIBUTE = "gcp.resource.destination.id";
89-
90-
// Visible for testing
9189
}

0 commit comments

Comments
 (0)