Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

Commit 98bb43d

Browse files
authored
[ggj][codegen] fix: handle clientStreamingCall in generated tests (#586)
* fix: fix dep ordering in Bazel dedupe rules * fix: use lowerCamelCase for string types in DefaultValueComposer * fix: handle clientStreamingCall in generated tests
1 parent 1cc2b77 commit 98bb43d

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/main/java/com/google/api/generator/gapic/composer/ServiceClientTestClassComposer.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1089,7 +1089,8 @@ private static MethodDefinition createStreamingRpcTestMethod(
10891089
.setName("requestObserver")
10901090
.build());
10911091
List<Expr> callableMethodArgs = new ArrayList<>();
1092-
if (!method.stream().equals(Method.Stream.BIDI)) {
1092+
if (!method.stream().equals(Method.Stream.BIDI)
1093+
&& !method.stream().equals(Method.Stream.CLIENT)) {
10931094
callableMethodArgs.add(requestVarExpr);
10941095
}
10951096
callableMethodArgs.add(responseObserverVarExpr);
@@ -1361,7 +1362,8 @@ private static List<Statement> createStreamingRpcExceptionTestStatements(
13611362
.build());
13621363

13631364
List<Expr> callableMethodArgs = new ArrayList<>();
1364-
if (!method.stream().equals(Method.Stream.BIDI)) {
1365+
if (!method.stream().equals(Method.Stream.BIDI)
1366+
&& !method.stream().equals(Method.Stream.CLIENT)) {
13651367
callableMethodArgs.add(requestVarExpr);
13661368
}
13671369
callableMethodArgs.add(responseObserverVarExpr);

src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClientTest.golden

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -424,8 +424,7 @@ public class EchoClientTest {
424424
MockStreamObserver<EchoResponse> responseObserver = new MockStreamObserver<>();
425425

426426
ClientStreamingCallable<EchoRequest, EchoResponse> callable = client.collectCallable();
427-
ApiStreamObserver<EchoRequest> requestObserver =
428-
callable.clientStreamingCall(request, responseObserver);
427+
ApiStreamObserver<EchoRequest> requestObserver = callable.clientStreamingCall(responseObserver);
429428

430429
requestObserver.onNext(request);
431430
requestObserver.onCompleted();
@@ -449,8 +448,7 @@ public class EchoClientTest {
449448
MockStreamObserver<EchoResponse> responseObserver = new MockStreamObserver<>();
450449

451450
ClientStreamingCallable<EchoRequest, EchoResponse> callable = client.collectCallable();
452-
ApiStreamObserver<EchoRequest> requestObserver =
453-
callable.clientStreamingCall(request, responseObserver);
451+
ApiStreamObserver<EchoRequest> requestObserver = callable.clientStreamingCall(responseObserver);
454452

455453
requestObserver.onNext(request);
456454

0 commit comments

Comments
 (0)