Skip to content

Commit 9f1bcd8

Browse files
committed
fix: address code quality flags
1 parent 0ae245d commit 9f1bcd8

2 files changed

Lines changed: 12 additions & 5 deletions

File tree

gax-java/gax-httpjson/src/test/java/com/google/api/gax/httpjson/HttpJsonCallOptionsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public class HttpJsonCallOptionsTest {
4141
private final HttpJsonCallOptions.Builder OPTIONS_BUILDER = HttpJsonCallOptions.newBuilder();
4242

4343
@Test
44-
public void testTracer() {
44+
void testTracer() {
4545
ApiTracer tracer = Mockito.mock(ApiTracer.class);
4646
HttpJsonCallOptions options = OPTIONS_BUILDER.setTracer(tracer).build();
4747
assertThat(options.getTracer()).isSameInstanceAs(tracer);

gax-java/gax/src/test/java/com/google/api/gax/tracing/BaseApiTracerTest.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
*/
3030
package com.google.api.gax.tracing;
3131

32+
import static com.google.common.truth.Truth.assertThat;
33+
3234
import org.junit.jupiter.api.Test;
3335

3436
public class BaseApiTracerTest {
@@ -161,9 +163,14 @@ public void testBatchRequestSent() {
161163
}
162164

163165
@Test
164-
public void testRecordResponseSize() {
165-
BaseApiTracer tracer = new BaseApiTracer();
166-
tracer.recordResponseSize(10);
167-
// No-op, so nothing to verify.
166+
void testRecordResponseSize() {
167+
Throwable notExpected = null;
168+
try {
169+
BaseApiTracer tracer = new BaseApiTracer();
170+
tracer.recordResponseSize(10);
171+
} catch (Exception ex) {
172+
notExpected = ex;
173+
}
174+
assertThat(notExpected).isNull();
168175
}
169176
}

0 commit comments

Comments
 (0)