Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

Commit ba55a34

Browse files
committed
test(o11y): remove assertions for deprecated rpc.grpc.status_code
1 parent 9f2ecd9 commit ba55a34

3 files changed

Lines changed: 0 additions & 24 deletions

File tree

gax-java/gax/src/test/java/com/google/api/gax/tracing/ObservabilityUtilsTest.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,6 @@ void testPopulateStatusAttributes_grpc_success() {
120120
ObservabilityUtils.populateStatusAttributes(attributes, null, ApiTracerContext.Transport.GRPC);
121121
assertThat(attributes)
122122
.containsEntry(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE, "OK");
123-
assertThat(attributes)
124-
.containsEntry(
125-
ObservabilityAttributes.RPC_GRPC_STATUS_ATTRIBUTE, (long) StatusCode.Code.OK.ordinal());
126123
}
127124

128125
@Test
@@ -133,10 +130,6 @@ void testPopulateStatusAttributes_grpc_apiException() {
133130
ObservabilityUtils.populateStatusAttributes(attributes, error, ApiTracerContext.Transport.GRPC);
134131
assertThat(attributes)
135132
.containsEntry(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE, "NOT_FOUND");
136-
assertThat(attributes)
137-
.containsEntry(
138-
ObservabilityAttributes.RPC_GRPC_STATUS_ATTRIBUTE,
139-
(long) StatusCode.Code.NOT_FOUND.ordinal());
140133
}
141134

142135
@Test
@@ -146,10 +139,6 @@ void testPopulateStatusAttributes_grpc_cancellationException() {
146139
ObservabilityUtils.populateStatusAttributes(attributes, error, ApiTracerContext.Transport.GRPC);
147140
assertThat(attributes)
148141
.containsEntry(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE, "CANCELLED");
149-
assertThat(attributes)
150-
.containsEntry(
151-
ObservabilityAttributes.RPC_GRPC_STATUS_ATTRIBUTE,
152-
(long) StatusCode.Code.CANCELLED.ordinal());
153142
}
154143

155144
@Test

gax-java/gax/src/test/java/com/google/api/gax/tracing/SpanTracerTest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,6 @@ void testAttemptSucceeded_grpc() {
9696

9797
assertThat(attrsCaptor.getValue())
9898
.containsEntry(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE, "OK");
99-
assertThat(attrsCaptor.getValue())
100-
.containsEntry(
101-
ObservabilityAttributes.RPC_GRPC_STATUS_ATTRIBUTE,
102-
(long) com.google.api.gax.rpc.StatusCode.Code.OK.ordinal());
10399
}
104100

105101
@Test
@@ -159,10 +155,6 @@ public Object getTransportCode() {
159155

160156
assertThat(attrsCaptor.getValue())
161157
.containsEntry(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE, "NOT_FOUND");
162-
assertThat(attrsCaptor.getValue())
163-
.containsEntry(
164-
ObservabilityAttributes.RPC_GRPC_STATUS_ATTRIBUTE,
165-
(long) com.google.api.gax.rpc.StatusCode.Code.NOT_FOUND.ordinal());
166158
}
167159

168160
@Test

java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITOtelTracing.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,6 @@ void testTracing_successfulEcho_grpc() throws Exception {
150150
AttributeKey.stringKey(
151151
ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE)))
152152
.isEqualTo("OK");
153-
assertThat(
154-
attemptSpan
155-
.getAttributes()
156-
.get(AttributeKey.longKey(ObservabilityAttributes.RPC_GRPC_STATUS_ATTRIBUTE)))
157-
.isEqualTo(0L);
158153
}
159154
}
160155

0 commit comments

Comments
 (0)