Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .kokoro/nightly/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# For google-cloud-java, only test specific handwritten libraries included in the monorepo. This is to
# help speed up the execution as building the entire repo is an expensive operation. Specify the nested
# `google-cloud-*` path (except for grafeas as it doesn't have one) because maven -pl will only build the
# specified folder (i.e. parent folder) and ignore all the related sub-modules inside
google_cloud_java_handwritten_maven_args="java-grafeas,java-vertexai/google-cloud-vertexai,java-resourcemanager/google-cloud-resourcemanager,java-translate/google-cloud-translate"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the handwritten modules written out again. This is separate from the list in the binary script as this also includes the proto modules.


# Checks that the protobuf compatibility scripts provide non-empty input
function validate_protobuf_compatibility_script_inputs {
# Comma-delimited list of repos to test
Expand Down
12 changes: 10 additions & 2 deletions .kokoro/nightly/downstream-protobuf-binary-compatibility.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,16 @@ for repo in ${REPOS_UNDER_TEST//,/ }; do # Split on comma
# Perform testing on main (with latest changes). Shallow copy as history is not important
git clone "https://github.com/googleapis/${repo}.git" --depth=1
pushd "${repo}"
# Install all repo modules to ~/.m2 (there can be multiple relevant artifacts to test i.e. core, admin, control)
mvn -B -ntp install -T 1C -DskipTests -Dclirr.skip -Denforcer.skip

if [ "${repo}" == "google-cloud-java" ]; then
# The `-am` command also builds anything these libraries depend on (i.e. proto-* and grpc-* sub modules)
mvn clean install -B -V -ntp -T 1C -DskipTests -Dclirr.skip -Denforcer.skip -Dmaven.javadoc.skip \
-pl "${google_cloud_java_handwritten_maven_args}" -am
else
# Install all repo modules to ~/.m2 (there can be multiple relevant artifacts to test i.e. core, admin, control)
mvn clean install -B -V -ntp -T 1C -DskipTests -Dclirr.skip -Denforcer.skip -Dmaven.javadoc.skip
fi


linkage_checker_arguments=""
build_program_arguments "${repo}"
Expand Down
22 changes: 18 additions & 4 deletions .kokoro/nightly/downstream-protobuf-source-compatibility.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,25 @@ for repo in ${REPOS_UNDER_TEST//,/ }; do # Split on comma

# Compile the Handwritten Library with the Protobuf-Java version to test source compatibility
# Run unit tests to help check for any behavior differences (dependant on coverage)
mvn clean test -B -V -ntp \
-Dclirr.skip=true \
-Denforcer.skip=true \
-Dmaven.javadoc.skip=true \
if [ "${repo}" == "google-cloud-java" ]; then
# The `-am` command also builds anything these libraries depend on (i.e. proto-* and grpc-* sub modules)
mvn clean test -B -V -ntp \
-Dclirr.skip \
-Denforcer.skip \
-Dmaven.javadoc.skip \
-Denforcer.skip \
-Dprotobuf.version=${PROTOBUF_RUNTIME_VERSION} \
-pl "${google_cloud_java_handwritten_maven_args}" -am \
-T 1C
else
mvn clean test -B -V -ntp \
-Dclirr.skip \
-Denforcer.skip \
-Dmaven.javadoc.skip \
-Denforcer.skip \
-Dprotobuf.version=${PROTOBUF_RUNTIME_VERSION} \
-T 1C
fi

popd
done
Loading