chore: allow generation-input as folder that supplies config and vers…#3700
Merged
chore: allow generation-input as folder that supplies config and vers…#3700
Conversation
…t and adjust unit test. Add another unit test.
|
|
zhumin8
commented
Mar 17, 2025
| # does special handling when a method is annotated with @main.command() | ||
| generate_impl( | ||
| generation_config_path=config_path, | ||
| generation_input=None, |
Contributor
Author
There was a problem hiding this comment.
this change is needed for the unit test, but not for real usage, as when not specified "click" would pass it in as None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ions file.
This change adds
--generation-inputoption to generation command, only intend to be used when--generation-config-pathis not provided. If none of these 2 provided, then default behavior does not change.Also added a clean up to delete the temp output folder created in generation process. This should only be an improvement to local dev workflow.
cc. @ldetmer