This repository was archived by the owner on May 14, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
chore(hermetic-build): include .github template updates as part of generation #3723
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1bb6936
chore(hermetic-build): include .kokoro and .github templates
diegomarquezp 4a59a65
update graal configs
diegomarquezp c25a14a
include universe domain changes
diegomarquezp 56c6f1c
Revert "include universe domain changes"
diegomarquezp a2effdc
remove single line unwanted templates
diegomarquezp 364b79f
adapt to linter
diegomarquezp df9a033
use xtrace on local setups
diegomarquezp c908f7b
use abstract path to jar in instructions
diegomarquezp 755c0de
restore .kokoro folder
diegomarquezp cb5a1ca
do not update .kokoro templates for now
diegomarquezp b66af92
remove CODEOWNERS template
diegomarquezp 88e6edb
chore: include cloud-java-bot in ignored authors of generated files
diegomarquezp b136655
format setup.py
diegomarquezp b9a7d01
Merge branch 'main' into fix-template-updates
diegomarquezp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
hermetic_build/library_generation/owlbot/templates/java_library/.github/CODEOWNERS
This file was deleted.
Oops, something went wrong.
12 changes: 12 additions & 0 deletions
12
...ic_build/library_generation/owlbot/templates/java_library/.github/generated-files-bot.yml
|
suztomo marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| externalManifests: | ||
| - type: json | ||
| file: 'synth.metadata' | ||
| jsonpath: '$.generatedFiles[*]' | ||
| - type: json | ||
| file: '.github/readme/synth.metadata/synth.metadata' | ||
| jsonpath: '$.generatedFiles[*]' | ||
| ignoreAuthors: | ||
| - 'renovate-bot' | ||
| - 'yoshi-automation' | ||
| - 'release-please[bot]' | ||
| - 'gcf-owl-bot[bot]' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,10 @@ | |
| "owlbot/src/poms/*.py", | ||
| "owlbot/templates/clirr/*.j2", | ||
| "owlbot/templates/poms/*.j2", | ||
| "owlbot/templates/java_library/.github/**/*", | ||
| # TODO: uncomment this line after https://github.com/googleapis/sdk-platform-java/pull/3723 | ||
| # has been merged. | ||
| #"owlbot/templates/java_library/.kokoro/**/*", | ||
| "owlbot/templates/java_library/**/*", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we still need this line?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, there are files outside |
||
| ], | ||
| "synthtool": ["owlbot/synthtool/**/*"], | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would rerun the same command can solve the permission issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm linkhas effect in the current shell session. My guess is that what's in an old session may get its permissions overriden.