chore: Add renovate custom manager to update upper-bound files#3894
chore: Add renovate custom manager to update upper-bound files#3894
Conversation
|
|
product-auto-label
Bot
added
size: l
lqiu96
force-pushed
the
renovate-bot-upper-bound-file
branch
from
5e8d7b3 to
ba9bb67
Compare
product-auto-label
Bot
added
size: m
| <properties> | ||
| <skipUnitTests>false</skipUnitTests> | ||
| <checkstyle.header.file>java.header</checkstyle.header.file> | ||
| <maven.compiler.release>8</maven.compiler.release> |
There was a problem hiding this comment.
I think changes in this file is unintentional? If yes, can we revert it?
There was a problem hiding this comment.
Moved the non-dependency property up (I think above is moreso a section for maven plugins.
| javax.annotation:javax.annotation-api,javax.annotation-api=1.3.2 | ||
| io.grpc:grpc-bom,grpc=1.74.0 | ||
| com.google.auth:google-auth-library-bom,google.auth=1.37.1 | ||
| com.google.http-client:google-http-client,google.http-client=1.47.1 | ||
| com.google.code.gson:gson,gson=2.13.1 |
There was a problem hiding this comment.
These may have some old versions that weren't merged properly. I think we should see renovate-bot raise a PR for these once this is merged in.
There was a problem hiding this comment.
Where are the old versions pulled from? Can we keep the latest versions?
There was a problem hiding this comment.
These are just old versions from this stale PR. Hopefully renovate bot can group the deps in these files in one deps PR.
There was a problem hiding this comment.
SG. As long as we upgrade them before releasing sdk-platform-java, we should be good.
There was a problem hiding this comment.
SG. As long as we upgrade them before releasing sdk-platform-java, we should be good.
I will merge this in and test this. Hopefully this should all come in as one big PR!
|
|
Dependencies CI Test: https://github.com/googleapis/sdk-platform-java/actions/runs/18327368470/job/52195017520 ## Changes In order to keep the current Maven pom.xml files the same, we create a new format in the dependencies.txt file: `{GroupID}:{ArtifactID},{MavenPropertyID}={Version}`. The `GroupID`, `ArtifactID`, and `Version` values are by renovate bot to determine there should be a dependency bump. The `MavenPropertyID` and `Version` values are used to build the maven test command. The format may not look intuitive and can be changed in the future. Values/ Separators were chosen so that it doesn't have any weird edge cases/ impact in shell scripts (avoiding ';', '*', '|' characters) ## Local Renovate Bot Invocation Local invocation of renovate shows that it is able to match the versions: ``` { "depName": "com.fasterxml.jackson:jackson-bom", "currentValue": "2.19.2", "datasource": "maven", "replaceString": "com.fasterxml.jackson:jackson-bom=2.19.2\n", "updates": [ { "bucket": "non-major", "newVersion": "2.20.0", "newValue": "2.20.0", "releaseTimestamp": "2025-08-28T22:48:03.000Z", "newVersionAgeInDays": 0, "newMajor": 2, "newMinor": 20, "newPatch": 0, "updateType": "minor", "isBreaking": false, "branchName": "renovate/com.fasterxml.jackson-jackson-bom-2.x" } ], ... ], "matchStrings": ["(?<depName>.*)=(?<currentValue>.*)\\n"], "datasourceTemplate": "maven", "packageFile": "dependencies.txt" } ```
2 participants
Dependencies CI Test: https://github.com/googleapis/sdk-platform-java/actions/runs/18327368470/job/52195017520
Changes
In order to keep the current Maven pom.xml files the same, we create a new format in the dependencies.txt file:
{GroupID}:{ArtifactID},{MavenPropertyID}={Version}. TheGroupID,ArtifactID, andVersionvalues are by renovate bot to determine there should be a dependency bump. TheMavenPropertyIDandVersionvalues are used to build the maven test command.The format may not look intuitive and can be changed in the future. Values/ Separators were chosen so that it doesn't have any weird edge cases/ impact in shell scripts (avoiding ';', '*', '|' characters)
Local Renovate Bot Invocation
Local invocation of renovate shows that it is able to match the versions: