Skip to content

ci: update showcase tests and build java tests to JDK 25#3918

Merged
mpeddada1 merged 10 commits intomainfrom
jdk-25
Oct 2, 2025
Merged

ci: update showcase tests and build java tests to JDK 25#3918
mpeddada1 merged 10 commits intomainfrom
jdk-25

Conversation

@mpeddada1
Copy link
Copy Markdown
Contributor

@mpeddada1 mpeddada1 commented Oct 2, 2025 •
edited
Loading

Skipping the format check (there still appear to be some JDK 25 issues spotify/fmt-maven-plugin#210).

@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Oct 2, 2025
@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Oct 2, 2025 

Error:  Failed to execute goal com.spotify.fmt:fmt-maven-plugin:2.25:check (default-cli) on project gapic-showcase: Execution default-cli of goal com.spotify.fmt:fmt-maven-plugin:2.25:check failed: An API incompatibility was encountered while executing com.spotify.fmt:fmt-maven-plugin:2.25:check: java.lang.NoSuchMethodError: null

@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Oct 2, 2025

Updating fmt-maven-plugin also results in: Execution default-cli of goal com.spotify.fmt:fmt-maven-plugin:2.29:check failed: An API incompatibility was encountered while executing com.spotify.fmt:fmt-maven-plugin:2.29:check: java.lang.NoSuchMethodError: null There still apear to be open issues regarding JDK 25 support for the fmt-maven-plugin: spotify/fmt-maven-plugin#210

@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Oct 2, 2025 

Error:  Errors: 
Error:    BaseServiceExceptionTest.testTranslateAndThrow:128 » IllegalArgument Could not create type
Error:    BaseEmulatorHelperTest.testEmulatorHelper:94 » IllegalArgument Could not create type
Error:    BaseEmulatorHelperTest.testEmulatorHelperDownloadWithRetries:142 » IllegalArgument Could not create type
Error:    BaseEmulatorHelperTest.testEmulatorHelperMultipleRunners:178 » IllegalArgument Could not create type
Error:    BaseEmulatorHelperTest.testEmulatorHelperThreeten:114 » IllegalArgument Could not create type
[INFO] 
Error:  Tests run: 218, Failures: 0, Errors: 5, Skipped: 0

@diegomarquezp
deps: update byte-buddy to 1.17.7
d27fc29 
easymock/easymock#547 (comment) indicates earlier versions used to shade byte-buddy, not anymore.
@diegomarquezp
deps: update easymock to 5.6.0
bed5b7f 
Fixes JDK25 issue in easymock/easymock#760
@diegomarquezp
Copy link
Copy Markdown
Contributor

diegomarquezp commented Oct 2, 2025

easymock/easymock#760 indicates easymock 5.6.0 solved JDK 25 compatibility. Additionally, easymock stopped shading byte-buddy in easymock/easymock#547, so we need to also use the newer version they try to bring.

diegomarquezp
diegomarquezp previously approved these changes Oct 2, 2025
View reviewed changes
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 2, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 2, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mpeddada1 mpeddada1 merged commit 90b0a33 into main Oct 2, 2025
57 of 60 checks passed
@mpeddada1 mpeddada1 deleted the jdk-25 branch October 2, 2025 18:10
lqiu96 pushed a commit that referenced this pull request Feb 12, 2026
@mpeddada1 @diegomarquezp @lqiu96
ci: update showcase tests and build java tests to JDK 25 (#3918)
7a36319 
Skipping the format check (there still appear to be some JDK 25 issues
spotify/fmt-maven-plugin#210).

---------

Co-authored-by: Diego Marquez <diegomarquezp@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpeddada1 @diegomarquezp