Skip to content
This repository was archived by the owner on Jun 16, 2019. It is now read-only.

Add option to ignore hidden markers#68

Open
maechler wants to merge 2 commits into
googlearchive:gh-pagesfrom
maechler:gh-pages
Open

Add option to ignore hidden markers#68
maechler wants to merge 2 commits into
googlearchive:gh-pagesfrom
maechler:gh-pages

Conversation

@maechler

Copy link
Copy Markdown

I added an option to ignore hidden markers when creating the cluster in the function "createClusters_".
The default value is set to false, which reflects the current state.

das-peter pushed a commit to CandoImage/js-marker-clusterer that referenced this pull request Jul 29, 2016
@Remo

Remo commented Oct 7, 2016

Copy link
Copy Markdown
Contributor

I think I've had a similar problem: #44
My approach is a bit different though. I'm adding all marker and only return those that are visible.
That way I can dynamically change the visibility of a marker. Is that something you've tested, maybe I've missed something in your change.

@maechler

maechler commented Oct 8, 2016

Copy link
Copy Markdown
Author

I just had a look at the code I wrote then, I am manually calling repaint() on the marker clusterer object after I changed the visibility of the markers. I do not think that is a big problem, apart from that it works like a charm.
Does your solution work without having to call repaint() ?

Anyways..it does not seem like this repository is actively maintained..

@Remo

Remo commented Oct 9, 2016

Copy link
Copy Markdown
Contributor

I see! I think my change did the same, I just needed more code ;-)
I'm thinking about forking this repo and merge some of the pull requests.

@Remo

Remo commented Dec 6, 2016

Copy link
Copy Markdown
Contributor

@maechler going to merge this in our fork over here gmaps-marker-clusterer/gmaps-marker-clusterer#7

@maechler

maechler commented Dec 6, 2016

Copy link
Copy Markdown
Author

Great! thanks. It's nice to see that the code is now in a repository where it can be maintained!

@krisgale-zz

krisgale-zz commented Jun 29, 2018

Copy link
Copy Markdown

just added it to a work-in-progress... and this version works great!
@brendankenny @moiarcsan @maechler ship it. it's a small but Very useful addition.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants