feat: enrich assign_server_event with outcome and configuration#577
Merged
Conversation
hjjackyang
approved these changes
Apr 28, 2026
kevineger
force-pushed
the
keger/telem-assign-server-outcome
branch
from
bdea926 to
f14738b
Compare
Captures the requested configuration (variant, accelerator, shape, version), whether one or more fallback accelerators were attempted, and the final outcome via a new nested `AssignmentOutcome` enum distinguishing success from `ASSIGNMENT_OUTCOME_ACCELERATOR_UNAVAILABLE`, `ASSIGNMENT_OUTCOME_ALL_ACCELERATORS_UNAVAILABLE`, `ASSIGNMENT_OUTCOME_TOO_MANY_ASSIGNMENTS`, `ASSIGNMENT_OUTCOME_INSUFFICIENT_QUOTA`, `ASSIGNMENT_OUTCOME_DENYLISTED`, and `ASSIGNMENT_OUTCOME_OTHER_FAILURE`. The enum is intentionally distinct from the top-level `Outcome` enum to avoid name collisions in generated code. `hadFallback` is derived in `assignServer` by comparing the returned assignment's accelerator to the requested one (success path), or by checking the thrown `AllAcceleratorsUnavailableError`'s `attempted` array length (failure path).
kevineger
force-pushed
the
keger/telem-assign-server-outcome
branch
from
f14738b to
bf96b3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures the requested configuration (variant, accelerator, shape, version),
whether one or more fallback accelerators were attempted, and the final outcome
via a new nested
AssignmentOutcomeenum distinguishing success fromASSIGNMENT_OUTCOME_ACCELERATOR_UNAVAILABLE,ASSIGNMENT_OUTCOME_ALL_ACCELERATORS_UNAVAILABLE,ASSIGNMENT_OUTCOME_TOO_MANY_ASSIGNMENTS,ASSIGNMENT_OUTCOME_INSUFFICIENT_QUOTA,ASSIGNMENT_OUTCOME_DENYLISTED, andASSIGNMENT_OUTCOME_OTHER_FAILURE. The enum is intentionally distinct from thetop-level
Outcomeenum to avoid name collisions in generated code.hadFallbackis derived inassignServerby comparing the returnedassignment's accelerator to the requested one (success path), or by checking
the thrown
AllAcceleratorsUnavailableError'sattemptedarray length(failure path).
Proto changes: cl/903978346