feat: log telemetry for low/depleted CCU balance notifications#578
Merged
Conversation
hjjackyang
requested changes
Apr 28, 2026
hjjackyang
left a comment
hjjackyang
left a comment
Contributor
There was a problem hiding this comment.
Similar test-related comments as other PRs, but I have a stronger opinion to change these ones given the confusing test names and loop logic inside the test, hence requested changes.
kevineger
force-pushed
the
keger/telem-low-ccu-notification
branch
from
506073f to
846d760
Compare
hjjackyang
approved these changes
Apr 29, 2026
Captures the severity of the notification (`SEVERITY_LOW` warning or `SEVERITY_DEPLETED` error), the user's subscription tier, and whether the user clicked the call-to-action (vs. dismissed the notification). The event is logged after the notification's promise resolves so the `clicked_action` outcome is captured. Pairs with `upgrade_to_pro_event` to enable funnel analysis from notification to upgrade. `telemetry.logLowCcuNotification` accepts the Colab-level `SubscriptionTier` directly and converts it to the proto-shaped top-level `SubscriptionTier` enum internally, keeping callers free of the conversion.
kevineger
force-pushed
the
keger/telem-low-ccu-notification
branch
from
8dc8122 to
9b8c4a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures the severity of the notification (
SEVERITY_LOWwarning orSEVERITY_DEPLETEDerror), the user's subscription tier, and whether the userclicked the call-to-action (vs. dismissed the notification).
The event is logged after the notification's promise resolves so the
clicked_actionoutcome is captured. Pairs withupgrade_to_pro_eventtoenable funnel analysis from notification to upgrade.
telemetry.logLowCcuNotificationaccepts the Colab-levelSubscriptionTierdirectly and converts it to the proto-shaped top-level
SubscriptionTierenuminternally, keeping callers free of the conversion.
Proto changes: cl/903985928