Skip to content

fix: make Prettier checks work on Windows#641

Open
dipeshbabu wants to merge 1 commit into
googlecolab:mainfrom
dipeshbabu:agent/fix-prettier-windows-line-endings
Open

fix: make Prettier checks work on Windows#641
dipeshbabu wants to merge 1 commit into
googlecolab:mainfrom
dipeshbabu:agent/fix-prettier-windows-line-endings

Conversation

@dipeshbabu

Copy link
Copy Markdown
Contributor

Summary

  • allow Prettier to accept the checkout's existing line-ending style
  • keep formatting checks consistent on Windows when Git checks out text files as CRLF

Why

With core.autocrlf=true, a clean Windows checkout uses CRLF line endings. Prettier's default LF setting causes npm run format:check to report nearly every tracked text file even though the Git worktree is clean.

Setting endOfLine to auto keeps the existing formatting rules while making the check platform-independent.

Validation

  • npm run format:check
  • npm run typecheck
  • npm run lint (0 errors; one warning in generated src/colab-config.ts)
  • npm run test:unit (1,156 passing)
  • CSpell check used by CI (199 files, 0 issues)
  • targeted Prettier check under Node 22.17.0 from .nvmrc

@dipeshbabu dipeshbabu marked this pull request as ready for review July 10, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant