Skip to content

fix: Relax secrets.properties enforcement for CI and Release builds#24

Merged
dkhawk merged 2 commits into
mainfrom
fix/secrets-gradle-enforcement
Jan 27, 2026
Merged

fix: Relax secrets.properties enforcement for CI and Release builds#24
dkhawk merged 2 commits into
mainfrom
fix/secrets-gradle-enforcement

Conversation

@dkhawk

@dkhawk dkhawk commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

Relaxes the strict secrets.properties check. It now only throws an exception for local Debug builds if the file is missing/invalid. CI builds (detected via CI env var) and Release builds are allowed to proceed without it.

@dkhawk dkhawk requested a review from kikoso January 27, 2026 18:45
Comment thread Maps3DSamples/ApiDemos/java-app/build.gradle.kts

@kikoso kikoso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkhawk dkhawk merged commit 8b64d1e into main Jan 27, 2026
8 checks passed
@dkhawk dkhawk deleted the fix/secrets-gradle-enforcement branch January 27, 2026 19:38
googlemaps-bot pushed a commit that referenced this pull request Jan 27, 2026
# [1.4.0](v1.3.0...v1.4.0) (2026-01-27)

### Bug Fixes

* bypass secrets check in CI ([#23](#23)) ([7c466f6](7c466f6))
* Relax secrets.properties enforcement for CI and Release builds ([#24](#24)) ([8b64d1e](8b64d1e))

### Features

* Add secrets plugin check to ApiDemos and Advanced samples ([#22](#22)) ([45bae7a](45bae7a))
@googlemaps-bot

Copy link
Copy Markdown

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dkhawk pushed a commit that referenced this pull request Mar 3, 2026
# [1.4.0](v1.3.0...v1.4.0) (2026-01-27)

### Bug Fixes

* bypass secrets check in CI ([#23](#23)) ([7c466f6](7c466f6))
* Relax secrets.properties enforcement for CI and Release builds ([#24](#24)) ([8b64d1e](8b64d1e))

### Features

* Add secrets plugin check to ApiDemos and Advanced samples ([#22](#22)) ([45bae7a](45bae7a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants