Skip to content

Fix: gradle secrets enforcement breaking tests#43

Open
dkhawk wants to merge 7 commits into
mainfrom
fix/gradle-secrets-enforcement-breaking-tests
Open

Fix: gradle secrets enforcement breaking tests#43
dkhawk wants to merge 7 commits into
mainfrom
fix/gradle-secrets-enforcement-breaking-tests

Conversation

@dkhawk
Copy link
Copy Markdown
Collaborator

@dkhawk dkhawk commented May 20, 2026

This PR fixes the CI failures where unit tests were crashing due to missing API keys.

Key changes:

  • Defined 'isCI' flag in the root build.gradle.kts.
  • Bypassed API key check in Maps3DJavaApplication when in CI or unit test mode.
  • Provided default manifest placeholders for API keys when in CI mode.

Centralize the secrets.properties enforcement logic into a single
authoritative check in the root build.gradle.kts file, removing
heavy duplication across six subprojects.

Replace brittle runtime environment checks with safe, build-time
BuildConfig.IS_CI constants for automated testing pipelines.

- Create root build.gradle.kts for workspace-wide validation
- Remove duplicated secrets-checking blocks from subproject scripts
- Inject BuildConfig.IS_CI and apply manifest placeholders in CI
- Update Application classes to respect BuildConfig.IS_CI early returns
- Untrack LOG.md and add to local exclude file
- Fill out missing PLACES_API_KEY in defaults properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant