Skip to content

Commit 3d4c444

Browse files
authored
Restore playwright.yml (#1189)
Restore the previous Build Changed Workspaces. Exclusion lists are an inherently bad idea.
1 parent cf30a31 commit 3d4c444

1 file changed

Lines changed: 6 additions & 14 deletions

File tree

.github/workflows/playwright.yml

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -89,27 +89,19 @@ jobs:
8989
if: steps.playwright-cache.outputs.cache-hit != 'true'
9090
run: npx playwright install --with-deps
9191

92-
93-
9492
- name: Build Changed Workspaces
95-
env:
96-
STEPS_GET_WORKSPACES_OUTPUTS_CHANGED_WORKSPACES: ${{ steps.get_workspaces.outputs.changed_workspaces }}
97-
# Projects to exclude:
98-
EXCLUDED_SAMPLES: "react-ui-kit-search-nearby react-ui-kit-search-text"
9993
run: |
100-
IFS=$'\n' CHANGED_WORKSPACES_ARRAY=(${STEPS_GET_WORKSPACES_OUTPUTS_CHANGED_WORKSPACES})
94+
IFS=$'\n'
95+
CHANGED_WORKSPACES_ARRAY=(${STEPS_GET_WORKSPACES_OUTPUTS_CHANGED_WORKSPACES})
10196
echo "Changed Workspaces Array: ${CHANGED_WORKSPACES_ARRAY[@]}"
97+
10298
echo "Building changed workspaces:"
10399
for workspace in "${CHANGED_WORKSPACES_ARRAY[@]}"; do
104-
# Check if the current workspace is in the excluded list
105-
if [[ " $EXCLUDED_SAMPLES " == *" $workspace "* ]]; then
106-
echo " - Skipping excluded workspace: samples/$workspace"
107-
continue
108-
fi
109-
110-
echo " - samples/$workspace"
100+
echo " - samples/$workspace"
111101
npm run build --workspace=samples/$workspace
112102
done
103+
env:
104+
STEPS_GET_WORKSPACES_OUTPUTS_CHANGED_WORKSPACES: ${{ steps.get_workspaces.outputs.changed_workspaces }}
113105

114106
- name: Generate Index (Run Once After Builds)
115107
run: bash samples/generate-index.sh

0 commit comments

Comments
 (0)