reenable several @typescript-eslint rules (#1398)

* reenable @typescript-eslint/no-unused-vars

* reenable @typescript-eslint/require-await @typescript-eslint/no-floating-promises @typescript-eslint/no-misused-promises

---------

Co-authored-by: William French <wfrench@google.com>

Author: chrisjshull

eslint.config.mjs

@@ -27,8 +27,8 @@ export default defineConfig([
             'prefer-const': 'error',
             'spaced-comment': ['error', 'always'],
 
-            // temporarily disabled for historic reasons:
-            'no-prototype-builtins': 'off',
+            // temporarily downgraded to warn for historic reasons:
+            'no-prototype-builtins': 'warn',
         },
     },
     {
@@ -40,13 +40,19 @@ export default defineConfig([
             },
         },
         rules: {
+            '@typescript-eslint/no-misused-promises': [
+                'error',
+                {
+                    checksVoidReturn: {
+                        arguments: false,
+                        attributes: false,
+                    },
+                },
+            ],
+
             // temporarily downgraded to warn for historic reasons:
             '@typescript-eslint/no-unsafe-member-access': 'warn',
-            '@typescript-eslint/no-unused-vars': 'warn',
             '@typescript-eslint/no-unsafe-assignment': 'warn',
-            '@typescript-eslint/require-await': 'warn',
-            '@typescript-eslint/no-floating-promises': 'warn',
-            '@typescript-eslint/no-misused-promises': 'warn',
             '@typescript-eslint/no-unsafe-call': 'warn',
             '@typescript-eslint/no-explicit-any': 'warn',
             '@typescript-eslint/no-namespace': 'warn',

samples/3d-accessibility-features/index.ts

@@ -82,5 +82,5 @@ async function initMap() {
     document.body.append(map);
 }
 
-initMap();
+void initMap();
 // [END maps_3d_accessibility_features]

samples/3d-camera-boundary/index.ts

@@ -19,5 +19,5 @@ async function initMap() {
     document.body.append(map);
 }
 
-initMap();
+void initMap();
 // [END maps_3d_camera_boundary]

samples/3d-camera-center/index.ts

@@ -36,5 +36,5 @@ async function initMap(): Promise<void> {
     });
 }
 
-initMap();
+void initMap();
 // [END maps_3d_camera_center]

samples/3d-camera-to-around/index.ts

@@ -61,10 +61,10 @@ async function init() {
     ); // Stop animation after flying around.
 
     // At any time stop the animation.
-    map.addEventListener('gmp-click', (event) => {
+    map.addEventListener('gmp-click', () => {
         map.stopCameraAnimation();
     });
 }
 
-init();
+void init();
 // [END maps_3d_camera_to_around]

samples/3d-clamp-mode/index.ts

@@ -48,7 +48,7 @@ async function init() {
     document.body.append(map);
 }
 
-init();
+void init();
 
 // Dropdown event listener
 const dropdown = document.getElementById(

samples/3d-coverage-map/index.ts

@@ -53,5 +53,5 @@ async function initMap() {
         }
     );
 }
-initMap();
+void initMap();
 // [END maps_3d_coverage_map]

samples/3d-label-toggle/index.ts

@@ -25,17 +25,6 @@ async function init() {
 
     document.body.append(map);
 
-    const locationCamera = {
-        center: {
-            lat: 21.263523536467105,
-            lng: -157.80663691939296,
-            altitude: 80.28936069489404,
-        },
-        range: 1500.8202963253427,
-        tilt: 76.9173260789542,
-        heading: -44.59196007522445,
-    };
-
     // Get the button element by its ID
     const toggleButton = document.getElementById('toggleButton')!;
     toggleButton.addEventListener('click', function () {
@@ -52,5 +41,5 @@ async function init() {
     });
 }
 
-init();
+void init();
 // [END maps_3d_label_toggle]

samples/3d-localization/index.ts

@@ -26,5 +26,5 @@ async function initMap() {
     document.body.append(map);
 }
 
-initMap();
+void initMap();
 // [END maps_3d_localization]

samples/3d-map-45-degree/index.ts

@@ -21,5 +21,5 @@ async function init() {
     document.body.append(map);
 }
 
-init();
+void init();
 // [END maps_3d_45_degree]