test: ensure nightly scheduled tests run all samples unconditionally (#1505)

* test: ensure nightly scheduled tests run all samples unconditionally

* Remove FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 variable

Removed FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 environment variable. The 3P actions plugins in use here all depend on Node 20, so this is not needed. In general the internal runner node can use a different version of Node (even though Node 20 is slated for deprecation in September of 2026).

Author: willum070

.github/workflows/tests.yml

@@ -34,7 +34,6 @@ on:
     - cron: "0 12 * * *"
 
 env:
-  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
   SKIP_DIST: ${{ github.event_name == 'pull_request' || github.event_name == 'schedule' }}
 
 concurrency:
@@ -216,6 +215,7 @@ jobs:
         run: npx playwright test e2e/samples.spec.ts
         env:
           CI: true
+          TEST_ALL_SAMPLES: "true"
 
       - name: Upload Test Report Artifact
         uses: actions/upload-artifact@v4

e2e/samples.spec.ts

@@ -42,6 +42,13 @@ const getChangedSampleFolders = (): string[] => {
             'find-changes.sh'
         );
 
+        if (process.env.TEST_ALL_SAMPLES === 'true') {
+            console.log(
+                'TEST_ALL_SAMPLES is set. Running tests for all samples.'
+            );
+            return getAllSampleFolders();
+        }
+
         if (!fs.existsSync(scriptPath)) {
             console.warn(
                 `Warning: find-changes.sh not found at ${scriptPath}. Running tests for all samples.`