fix even more build/typings issues

Author: chrisjshull

.github/workflows/tests.yml

@@ -108,6 +108,18 @@ jobs:
         if: env.HAS_CHANGES == 'true'
         run: npm install
 
+      - name: Prettier Check
+        if: env.HAS_CHANGES == 'true'
+        run: npx prettier ./samples/ --check --log-level warn
+        env:
+          CI: true
+
+      - name: ESLint Check
+        if: env.HAS_CHANGES == 'true'
+        run: npx eslint
+        env:
+          CI: true
+
       - name: Install Playwright Browsers
         if: steps.playwright-cache.outputs.cache-hit != 'true' && env.HAS_CHANGES == 'true'
         run: npx playwright install chromium --with-deps
@@ -133,18 +145,6 @@ jobs:
           env.HAS_CHANGES == 'true' ||
           contains(github.event.pull_request.paths.*, 'samples/generate-index.sh')
 
-      - name: Prettier Check
-        if: env.HAS_CHANGES == 'true'
-        run: npx prettier ./samples/ --check --log-level warn
-        env:
-          CI: true
-
-      - name: ESLint Check
-        if: env.HAS_CHANGES == 'true'
-        run: npx eslint
-        env:
-          CI: true
-
       - name: Run All Playwright Tests
         if: env.HAS_CHANGES == 'true'
         run: npx playwright test e2e/samples.spec.ts

.gitignore

@@ -6,7 +6,7 @@ samples/.env
 
 # Ignore dist files generated by build.
 samples/*/dist/
-samples/**/*.js
+samples/*/*.js
 
 # Ignore playwright outputs
 /test-results/

.prettierignore

@@ -1,4 +1,5 @@
 index.html
 package.json
 package-lock.json
-dist
+dist
+samples/*/*.js

e2e/samples.spec.ts

@@ -218,7 +218,7 @@ foldersToTest.forEach((sampleFolder) => {
                     typeof window.google.maps !== 'undefined'
                 );
             });
-            await expect(hasGoogleMaps).toBeTruthy();
+            expect(hasGoogleMaps).toBeTruthy();
 
             /** const mapElement = await page.locator('#map');
       if (await page.locator('#map').isVisible()) {

e2e/tsconfig.json

@@ -0,0 +1,7 @@
+{
+  "extends": "../tsconfig.base.json",
+  "compilerOptions": {
+    "rootDir": "."
+  },
+  "include": ["./*.ts"]
+}

eslint.config.mjs

@@ -8,7 +8,7 @@ import { defineConfig, globalIgnores } from 'eslint/config';
 import stylistic from '@stylistic/eslint-plugin';
 
 export default defineConfig([
-    globalIgnores(['**/dist/*', '**/package-lock.json']),
+    globalIgnores(['**/dist/*', 'samples/*/*.js', '**/package-lock.json']),
     {
         files: ['**/*.{js,mjs,cjs,ts,mts,cts}'],
         plugins: { js },
@@ -28,12 +28,33 @@ export default defineConfig([
             'spaced-comment': ['error', 'always'],
 
             // temporarily disabled for historic reasons:
-            '@typescript-eslint/no-unused-vars': 'off',
-            '@typescript-eslint/no-explicit-any': 'off',
-            '@typescript-eslint/no-namespace': 'off',
             'no-prototype-builtins': 'off',
         },
     },
+    {
+        files: ['**/*.ts', '**/*.tsx'],
+        extends: [...tseslint.configs.recommendedTypeChecked],
+        languageOptions: {
+            parserOptions: {
+                projectService: true,
+            },
+        },
+        rules: {
+            // temporarily downgraded to warn for historic reasons:
+            '@typescript-eslint/no-unsafe-member-access': 'warn',
+            '@typescript-eslint/no-unused-vars': 'warn',
+            '@typescript-eslint/no-unsafe-assignment': 'warn',
+            '@typescript-eslint/require-await': 'warn',
+            '@typescript-eslint/no-floating-promises': 'warn',
+            '@typescript-eslint/no-misused-promises': 'warn',
+            '@typescript-eslint/no-unsafe-call': 'warn',
+            '@typescript-eslint/no-explicit-any': 'warn',
+            '@typescript-eslint/no-namespace': 'warn',
+            '@typescript-eslint/no-unsafe-return': 'warn',
+            '@typescript-eslint/no-unsafe-argument': 'warn',
+            '@typescript-eslint/no-redundant-type-constituents': 'warn',
+        },
+    },
     {
         files: ['**/*.json'],
         plugins: { json },

samples/3d-map-roadmap/index.ts

@@ -3,11 +3,11 @@
  * Copyright 2026 Google LLC. All Rights Reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
-
+// TMP EMPTY LINE
 // [START maps_3d_map_roadmap]
 async function init() {
     const { Map3DElement } = await google.maps.importLibrary('maps3d');
-
+    // TMP EMPTY LINE
     const map = new Map3DElement({
         center: {
             lat: 37.79334535092104,
@@ -20,18 +20,18 @@ async function init() {
         mode: 'ROADMAP',
         internalUsageAttributionIds: ['gmp_git_jsapisamples_v1_3d-rendering'],
     });
-
+    // TMP EMPTY LINE
     document.body.append(map);
-
+    // TMP EMPTY LINE
     // Create the controls container
     const controls = document.createElement('div');
     controls.id = 'controls';
     controls.classList.add('map-mode-control');
-
+    // TMP EMPTY LINE
     // Create the select element
     const selector = document.createElement('select');
     selector.id = 'map-mode';
-
+    // TMP EMPTY LINE
     const modes = ['ROADMAP', 'SATELLITE', 'HYBRID'];
     modes.forEach((modeName) => {
         const option = document.createElement('option');
@@ -42,14 +42,14 @@ async function init() {
         }
         selector.appendChild(option);
     });
-
+    // TMP EMPTY LINE
     selector.addEventListener('change', function () {
         map.mode = this.value as google.maps.maps3d.MapMode;
     });
-
+    // TMP EMPTY LINE
     controls.appendChild(selector);
     document.body.appendChild(controls);
 }
-
+// TMP EMPTY LINE
 init();
 // [END maps_3d_map_roadmap]

samples/3d-map-styling/index.ts

@@ -3,11 +3,11 @@
  * Copyright 2026 Google LLC. All Rights Reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
-
+// TMP EMPTY LINE
 // [START maps_3d_map_styling]
 async function initMap() {
     const { Map3DElement } = await google.maps.importLibrary('maps3d');
-
+    // TMP EMPTY LINE
     const map = new Map3DElement({
         center: {
             lat: 37.75183154601466,
@@ -21,9 +21,9 @@ async function initMap() {
         mode: 'HYBRID',
         gestureHandling: 'COOPERATIVE',
     });
-
+    // TMP EMPTY LINE
     document.body.append(map);
 }
-
+// TMP EMPTY LINE
 initMap();
 // [END maps_3d_map_styling]

samples/3d-marker-click-event/index.ts

@@ -3,35 +3,35 @@
  * Copyright 2025 Google LLC. All Rights Reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
-
+// TMP EMPTY LINE
 // [START maps_3d_marker_click_event]
 async function initMap() {
     // Include the interactive marker class
     const { Map3DElement, Marker3DInteractiveElement } =
         await google.maps.importLibrary('maps3d');
-
+    // TMP EMPTY LINE
     // We will use this to place the camrea for the intial view but also to fly around the starting point.
     const originalCamera = {
         center: { lat: 39.1178, lng: -106.4452, altitude: 4395.4952 },
         range: 1500,
         tilt: 74,
         heading: 0,
     };
-
+    // TMP EMPTY LINE
     const map = new Map3DElement({
         ...originalCamera,
         mode: 'SATELLITE',
         gestureHandling: 'COOPERATIVE',
     });
-
+    // TMP EMPTY LINE
     // Create the interactive marker and set the attributes.
     const interactiveMarker = new Marker3DInteractiveElement({
         position: { lat: 39.1178, lng: -106.4452, altitude: 100 },
         altitudeMode: 'RELATIVE_TO_MESH',
         extruded: true,
         label: 'Mount Elbert',
     });
-
+    // TMP EMPTY LINE
     // Specify the action to take on click.
     interactiveMarker.addEventListener('gmp-click', (event) => {
         map.flyCameraAround({
@@ -40,11 +40,11 @@ async function initMap() {
             repeatCount: 1,
         });
     });
-
+    // TMP EMPTY LINE
     map.append(interactiveMarker);
-
+    // TMP EMPTY LINE
     document.body.append(map);
 }
-
+// TMP EMPTY LINE
 initMap();
 // [END maps_3d_marker_click_event]

samples/3d-marker-collision-behavior/index.ts

@@ -3,36 +3,36 @@
  * Copyright 2025 Google LLC. All Rights Reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
-
+// TMP EMPTY LINE
 // [START maps_3d_marker_collision_behavior]
 const markers: google.maps.maps3d.Marker3DElement[] = [];
-
+// TMP EMPTY LINE
 async function init() {
     // Request needed libraries.
     const { Map3DElement, Marker3DElement } =
         await google.maps.importLibrary('maps3d');
-
+    // TMP EMPTY LINE
     const map = new Map3DElement({
         center: { lat: 47.6094, lng: -122.339, altitude: 0 },
         range: 1000,
         mode: 'HYBRID',
         gestureHandling: 'COOPERATIVE',
     });
-
+    // TMP EMPTY LINE
     for (const [lng, lat] of positions) {
         const marker = new Marker3DElement({
             position: { lat, lng },
             // Try setting a different collision behavior here.
             collisionBehavior: 'REQUIRED',
         });
-
+        // TMP EMPTY LINE
         markers.push(marker);
         map.append(marker);
     }
-
+    // TMP EMPTY LINE
     document.body.append(map);
 }
-
+// TMP EMPTY LINE
 const positions = [
     [-122.3402, 47.6093],
     [-122.3402, 47.6094],
@@ -48,19 +48,19 @@ const positions = [
     [-122.3381, 47.6095],
     [-122.3378, 47.6095],
 ];
-
+// TMP EMPTY LINE
 init();
-
+// TMP EMPTY LINE
 const dropdown = document.getElementById(
     'selectElementId'
 ) as HTMLSelectElement;
 dropdown.addEventListener('change', drawMap);
-
+// TMP EMPTY LINE
 function drawMap(event) {
     for (const marker of markers) {
         marker.collisionBehavior =
             (dropdown.value as google.maps.CollisionBehavior) || 'REQUIRED';
     }
 }
-
+// TMP EMPTY LINE
 // [END maps_3d_marker_collision_behavior]