Skip to content

Exclude filtered sample folders from changed samples #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willum070 merged 1 commit into from
Mar 10, 2026
Merged

Exclude filtered sample folders from changed samples #1186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/samples.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const getAllSampleFolders = () => {
// Ensure we are only looking at directories within samplesDir, excluding find-changes.sh itself if it's a file
const filePath = path.join(samplesDir, file);
return fs.statSync(filePath).isDirectory();
}).filter(sampleFolder => !isExcluded(sampleFolder));
});
};

// Function to return only changed sample folders.
Expand Down Expand Up @@ -96,7 +96,7 @@ const getChangedSampleFolders = (): string[] => {
}

console.log("Running tests only for changed samples: ", validChangedFolders);
return validChangedFolders;
return validChangedFolders.filter(sampleFolder => !isExcluded(sampleFolder)); // Filter excluded samples.

} catch (error) {
console.error("Error running find-changes.sh. Skipping tests:", error);
Expand Down
Loading