Skip to content

fix: Reverts previous changes for exclusion. #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willum070 merged 1 commit into from
Mar 10, 2026
Merged

fix: Reverts previous changes for exclusion. #1187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions e2e/samples.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,6 @@ import childProcess, { execSync } from 'child_process';

const samplesDir = path.join(__dirname, '..', 'samples');

// Samples to exclude from build and e2e runs.
const excludedSamples = new Set<string>([
'react-ui-kit-place-details',
'react-ui-kit-search-nearby',
'react-ui-kit-search-text',
]);

const isExcluded = (sampleFolder: string) => excludedSamples.has(sampleFolder);

// Function to return all sample folders.
const getAllSampleFolders = () => {
return fs.readdirSync(samplesDir).filter((file) => {
Expand Down Expand Up @@ -96,7 +87,7 @@ const getChangedSampleFolders = (): string[] => {
}

console.log("Running tests only for changed samples: ", validChangedFolders);
return validChangedFolders.filter(sampleFolder => !isExcluded(sampleFolder)); // Filter excluded samples.
return validChangedFolders; // Filter excluded samples.

} catch (error) {
console.error("Error running find-changes.sh. Skipping tests:", error);
Expand All @@ -106,7 +97,7 @@ const getChangedSampleFolders = (): string[] => {

// Get changed folders, filtering out excluded ones.
//const foldersToTest = getChangedSampleFolders();
const foldersToTest = getChangedSampleFolders().filter(f => !isExcluded(f));
const foldersToTest = getChangedSampleFolders();

if (foldersToTest.length === 0) {
console.log("No sample folders found.");
Expand Down
Loading