feat: Allow for info window customization on advanced markers#862
Open
petereair wants to merge 1 commit intogooglemaps:mainfrom
Open
feat: Allow for info window customization on advanced markers#862petereair wants to merge 1 commit intogooglemaps:mainfrom
petereair wants to merge 1 commit intogooglemaps:mainfrom
Conversation
4 tasks
(cherry picked from commit 1bb27ca)
kikoso
force-pushed
the
info-window-customization
branch
from
18eee33 to
0c7d1ec
Compare
kikoso
reviewed
Apr 9, 2026
| * @param pinConfig the PinConfig object that will be used for the advanced marker | ||
| * @param iconView the custom view to be used on the advanced marker | ||
| * @param collisionBehavior the expected collision behavior | ||
| * @param infoWindowContent optional composable lambda expression for customizing the |
Collaborator
There was a problem hiding this comment.
AdvancedMarkerInfoWindow maps its trailing lambda to the infoWindow parameter of AdvancedMarkerImpl (which replaces the entire info window, including the frame/background), the KDoc should be updated to reflect that:
@param content optional composable lambda expression for customizing the entire info window
(this is also how it is documented in MarkerInfoWindow and AdvancedMarkerImpl)
kikoso
reviewed
Apr 9, 2026
| * @param pinConfig the PinConfig object that will be used for the advanced marker | ||
| * @param iconView the custom view to be used on the advanced marker | ||
| * @param collisionBehavior the expected collision behavior | ||
| * @param infoWindowContent optional composable lambda expression for customizing the |
Collaborator
There was a problem hiding this comment.
Update documentation here too.
Collaborator
|
@petereair , this looks good, I have left a couple of minor comments. Would you be able to add a sample to the Advanced Markers Activity? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the approach used by regular markers which has separate functions for customizing just the content and customizing the whole window. Currently there is no way to customize either.
This is a duplicate of #823 which I needed to close to open this under the correct account for the CLA.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #822 🦕