Skip to content

Commit 67767ef

Browse files
committed
fix: replace plugin ids with aliases and remove redundant kotlin-android plugin
1 parent 1df1cdc commit 67767ef

File tree

8 files changed

+17
-20
lines changed

8 files changed

+17
-20
lines changed

app/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
plugins {
1818
alias(libs.plugins.android.application)
19-
alias(libs.plugins.kotlin.android)
2019
alias(libs.plugins.secrets.gradle.plugin)
2120
}
2221

build-logic/convention/src/main/kotlin/PublishingConventionPlugin.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,7 @@ class PublishingConventionPlugin : Plugin<Project> {
4343
extensions.configure<MavenPublishBaseExtension> {
4444
configure(
4545
AndroidSingleVariantLibrary(
46-
variant = "release",
47-
sourcesJar = true,
48-
publishJavadocJar = true
46+
variant = "release"
4947
)
5048
)
5149

build.gradle.kts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616

1717
plugins {
1818
alias(libs.plugins.android.application) apply false
19-
alias(libs.plugins.kotlin.android) apply false
20-
id("org.jetbrains.dokka") version "2.1.0"
19+
alias(libs.plugins.dokka) apply false
2120
alias(libs.plugins.gradle.maven.publish) apply false
2221
alias(libs.plugins.secrets.gradle.plugin) apply false
2322
}

docs/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
plugins {
22
kotlin("jvm") apply false
3-
id("org.jetbrains.dokka")
3+
alias(libs.plugins.dokka)
44
}
55

66
dependencies {

gradle.properties

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ org.gradle.jvmargs=-Xmx1536m
1616
# https://developer.android.com/topic/libraries/support-library/androidx-rn
1717
android.useAndroidX=true
1818
# Automatically convert third-party libraries to use AndroidX
19-
android.enableJetifier=true
19+
# android.enableJetifier=true
2020
# Kotlin code style for this project: "official" or "obsolete":
2121
kotlin.code.style=official
2222

@@ -25,18 +25,20 @@ kotlin.code.style=official
2525
signing.keyId=
2626
signing.password=
2727
signing.secretKeyRingFile=
28-
android.defaults.buildfeatures.buildconfig=true
2928

3029
mavenCentralUsername=
3130
mavenCentralPassword=
3231

3332
# Migration to AGP 8.2.1
3433
android.nonTransitiveRClass=false
35-
android.nonFinalResIds=false
3634

3735
# Despite being deprecated, targeting lowest java version is needed to support old Android runtime
3836
android.javaCompile.suppressSourceTargetDeprecationWarning=true
3937

4038
# Add a property to enable automatic release to Maven Central (optional, but good for CI)
4139
# If true, publishToMavenCentral will also close and release the staging repository
42-
mavenCentralAutomaticRelease=false
40+
mavenCentralAutomaticRelease=false
41+
android.uniquePackageNames=false
42+
android.dependency.useConstraints=true
43+
android.r8.strictFullModeForKeepRules=false
44+
android.generateSyncIssueWhenLibraryConstraintsAreEnabled=false

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ truth = "1.4.5"
3232

3333
# --- Gradle Plugins ---
3434
# Versions for Gradle plugins used in the build process.
35-
agp = "8.13.2"
35+
agp = "9.0.1"
3636
dokkaGradlePlugin = "2.1.0"
3737
gradleMavenPublishPlugin = "0.36.0"
3838
jacocoAndroidGradlePlugin = "0.2.1"

maps-ktx/build.gradle.kts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,8 @@
1616
*/
1717

1818
plugins {
19-
alias(libs.plugins.kotlin.android)
2019
id("android.maps.ktx.PublishingConventionPlugin")
21-
id("org.jetbrains.dokka")
20+
alias(libs.plugins.dokka)
2221
}
2322

2423
android {
@@ -82,22 +81,23 @@ val generateArtifactIdFile = tasks.register("generateArtifactIdFile") {
8281
val outputDir = layout.buildDirectory.dir("generated/source/artifactId")
8382
val packageName = "com.google.maps.android.ktx.utils.meta"
8483
val packagePath = packageName.replace('.', '/')
85-
val outputFile = outputDir.get().file("$packagePath/ArtifactId.kt").asFile
84+
val outputFile = outputDir.get().file("$packagePath/AttributionId.java").asFile
8685

8786
outputs.file(outputFile)
8887

8988
doLast {
9089
outputFile.parentFile.mkdirs()
9190
outputFile.writeText(
9291
"""
93-
package $packageName
92+
package $packageName;
9493
9594
/**
9695
* Automatically generated object containing the library's attribution ID.
9796
* This is used to track library usage for analytics.
9897
*/
99-
public object AttributionId {
100-
public const val VALUE: String = "$attributionId"
98+
public final class AttributionId {
99+
public static final String VALUE = "$attributionId";
100+
private AttributionId() {}
101101
}
102102
""".trimIndent()
103103
)

maps-utils-ktx/build.gradle.kts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@
1515
*/
1616

1717
plugins {
18-
alias(libs.plugins.kotlin.android)
1918
id("android.maps.ktx.PublishingConventionPlugin")
20-
id("org.jetbrains.dokka")
19+
alias(libs.plugins.dokka)
2120
}
2221

2322
android {

0 commit comments

Comments
 (0)