fix: make isPlaceResult() type predicate more robust to JS API changes

PiperOrigin-RevId: 925638490

Author: mcreinhard

src/utils/place_utils.ts

@@ -21,8 +21,7 @@ import {isOpen} from './opening_hours.js';
 export function isPlaceResult(place: Place|PlaceResult): place is PlaceResult {
   // To avoid depending on loading the API at runtime, we do not use
   // `instanceof google.map.places.Place`.
-  // TODO: fix for property renaming safety?
-  return !place.hasOwnProperty('id');
+  return (place as Place).id === undefined;
 }
 
 /**

src/utils/place_utils_test.ts

@@ -12,7 +12,7 @@ import {Environment} from '../testing/environment.js';
 import {FakeLatLng} from '../testing/fake_lat_lng.js';
 import {makeFakePlace, SAMPLE_FAKE_PLACE, SAMPLE_FAKE_PLACE_RESULT} from '../testing/fake_place.js';
 
-import type {PlaceResult} from './googlemaps_types.js';
+import type {Place, PlaceResult} from './googlemaps_types.js';
 import {isPlaceResult, makePlaceFromPlaceResult, makeWaypoint, numericToPriceLevel, priceLevelToNumeric, renderAttribution} from './place_utils.js';
 
 type PriceLevel = google.maps.places.PriceLevel;
@@ -31,6 +31,18 @@ describe('isPlaceResult', () => {
     const fakePlace = makeFakePlace({id: 'some_id', displayName: 'Name'});
     expect(isPlaceResult(fakePlace)).toBe(false);
   });
+
+  it('says that a Place with an id getter is not a PlaceResult', () => {
+    class FakePlace {
+      get id() {
+        return 'some_id';
+      }
+      get displayName() {
+        return 'Name';
+      }
+    }
+    expect(isPlaceResult(new FakePlace() as Place)).toBe(false);
+  });
 });
 
 describe('priceLevelToNumeric', () => {