Skip to content

fix: performance improvement and less excessive logging. #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regeter merged 2 commits into from
Jul 24, 2025
Merged

fix: performance improvement and less excessive logging. #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2db235
fix: Remove excessive dataframe logging.
regeter Jul 24, 2025
c9d9250
fix: Prevent expensive map effects from running on every render
regeter Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class App extends React.Component {
selectedRowIndexPerDataset: [-1, -1, -1, -1, -1],
currentLogData: this.props.logData,
dynamicMarkerLocations: {},
visibleToggles: getVisibleToggles(this.props.logData.solutionType),
};
this.onSliderChangeDebounced = _.debounce((timeRange) => this.onSliderChange(timeRange), 25);
this.setFeaturedObject = this.setFeaturedObject.bind(this);
Expand Down Expand Up @@ -696,20 +697,21 @@ class App extends React.Component {
const data = await getUploadedData(index);
if (data && data.rawLogs && Array.isArray(data.rawLogs) && data.rawLogs.length > 0) {
const tripLogs = new TripLogs(data.rawLogs, data.solutionType);
const newVisibleToggles = getVisibleToggles(data.solutionType);

this.setState(
(prevState) => {
return {
activeDatasetIndex: index,
timeRange: { minTime: tripLogs.minDate.getTime(), maxTime: tripLogs.maxDate.getTime() },
initialMapBounds: data.bounds,
currentLogData: {
...prevState.currentLogData,
tripLogs: tripLogs,
solutionType: data.solutionType,
},
dynamicMarkerLocations: {}, // Clear markers when switching datasets
};
},
(prevState) => ({
activeDatasetIndex: index,
timeRange: { minTime: tripLogs.minDate.getTime(), maxTime: tripLogs.maxDate.getTime() },
initialMapBounds: data.bounds,
currentLogData: {
...prevState.currentLogData,
tripLogs: tripLogs,
solutionType: data.solutionType,
},
visibleToggles: newVisibleToggles,
dynamicMarkerLocations: {}, // Clear markers when switching datasets
}),
() => {
log(`Switched to dataset ${index}`);
log(`New time range: ${tripLogs.minDate} - ${tripLogs.maxDate}`);
Expand Down Expand Up @@ -768,10 +770,16 @@ class App extends React.Component {
}

render() {
const { featuredObject, timeRange, currentLogData, toggleOptions, extraColumns, dynamicMarkerLocations } =
this.state;
const {
featuredObject,
timeRange,
currentLogData,
toggleOptions,
extraColumns,
dynamicMarkerLocations,
visibleToggles,
} = this.state;
const selectedEventTime = featuredObject?.timestamp ? new Date(featuredObject.timestamp).getTime() : null;
const visibleToggles = getVisibleToggles(currentLogData.solutionType);

return (
<div className="app-container">
Expand Down
1 change: 0 additions & 1 deletion src/Dataframe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ function Dataframe({ featuredObject, extraColumns, onColumnToggle, onToggleMarke
}, []);

const shouldCollapse = useCallback(({ indexOrName, depth }) => {
log(`shouldCollapse called for indexOrName: '${indexOrName}', depth: ${depth}`);
if (depth === 1 && typeof indexOrName === "undefined") {
return false;
}
Expand Down
Loading