Skip to content

fix: Resolve Firefox crash by ensuring TaskLogs is initialized #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regeter merged 1 commit into from
Jul 24, 2025
Merged

fix: Resolve Firefox crash by ensuring TaskLogs is initialized #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import TimeSlider from "./TimeSlider";
import LogTable from "./LogTable";
import ToggleBar from "./ToggleBar";
import TripLogs from "./TripLogs";
import TaskLogs from "./TaskLogs";
import CloudLogging from "./CloudLogging";
import {
uploadFile,
Expand Down Expand Up @@ -59,7 +60,10 @@ class App extends React.Component {
activeMenuIndex: null,
initialMapBounds: null,
selectedRowIndexPerDataset: [-1, -1, -1, -1, -1],
currentLogData: this.props.logData,
currentLogData: {
...this.props.logData,
taskLogs: new TaskLogs(this.props.logData.tripLogs),
},
dynamicMarkerLocations: {},
visibleToggles: getVisibleToggles(this.props.logData.solutionType),
};
Expand Down Expand Up @@ -454,12 +458,14 @@ class App extends React.Component {
if (this.state.activeDatasetIndex === index) {
log(`handlePruneClick: Pruning active dataset ${index}, updating state.`);
const tripLogs = new TripLogs(data.rawLogs, data.solutionType);
const taskLogs = new TaskLogs(tripLogs);

this.setState(
(prevState) => ({
currentLogData: {
...prevState.currentLogData,
tripLogs: tripLogs,
taskLogs: taskLogs,
solutionType: data.solutionType,
},
}),
Expand Down Expand Up @@ -697,6 +703,7 @@ class App extends React.Component {
const data = await getUploadedData(index);
if (data && data.rawLogs && Array.isArray(data.rawLogs) && data.rawLogs.length > 0) {
const tripLogs = new TripLogs(data.rawLogs, data.solutionType);
const taskLogs = new TaskLogs(tripLogs);
const newVisibleToggles = getVisibleToggles(data.solutionType);

let newToggleOptions = { ...this.state.toggleOptions };
Expand All @@ -720,6 +727,7 @@ class App extends React.Component {
currentLogData: {
...prevState.currentLogData,
tripLogs: tripLogs,
taskLogs: taskLogs,
solutionType: data.solutionType,
},
visibleToggles: newVisibleToggles,
Expand Down
Loading