fix: Eliminate vehicle marker flicker on update#251
Merged
regeter merged 2 commits intogooglemaps:mainfrom Jul 24, 2025
Merged
Conversation
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
* fix: Eliminate vehicle marker flicker on row change * fix: excessive logging for larger files f317f92
googlemaps-bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
### [1.20.5](v1.20.4...v1.20.5) (2025-07-24) ### Bug Fixes * Eliminate vehicle marker flicker on update ([#251](#251)) ([f317f92](f317f92))
Contributor
|
🎉 This PR is included in version 1.20.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vehicle marker was being destroyed and recreated on every data update. During high-frequency updates, such as playing through a trip log, this caused a noticeable flicker as the marker would briefly disappear from the map between renders.
This change refactors the marker handling logic to persist the marker objects across renders. Instead of recreating the markers, their properties (e.g., position, rotation) are now updated directly using
setPosition()andsetIcon().This approach is more performant, results in a smooth update without flickering, and is the recommended pattern for frequently-updated map objects.