Skip to content

Commit 7f747f5

Browse files
Merge pull request #251 from domesticmouse/master
Fix for #248
2 parents e2b474d + ab35f32 commit 7f747f5

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/main/java/com/google/maps/GeoApiContext.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,9 @@ private <T, R extends ApiResponse<T>> PendingResult<T> getWithPath(Class<R> claz
210210
}
211211
url.append(encodedPath);
212212

213-
if (canUseClientId && clientId != null) {
214-
url.append("&signature=").append(urlSigner.getSignature(url.toString()));
213+
if (canUseClientId && urlSigner != null) {
214+
String signature = urlSigner.getSignature(url.toString());
215+
url.append("&signature=").append(signature);
215216
}
216217

217218
if (baseUrlOverride != null) {

src/test/java/com/google/maps/GeocodingApiTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ private void checkSydneyResult(GeocodingResult[] results) {
9898
assertNotNull(results[0].geometry.location);
9999
assertEquals(-33.8674869, results[0].geometry.location.lat, EPSILON);
100100
assertEquals(151.2069902, results[0].geometry.location.lng, EPSILON);
101-
assertEquals("ChIJP3Sa8ziYEmsRUKgyFmh9AQM", results[0].placeId);
102101
assertEquals(LocationType.APPROXIMATE, results[0].geometry.locationType);
103102
}
104103

0 commit comments

Comments
 (0)