Skip to content

fix: stop navigation forwarding service on cleanup on Android #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jokerttu wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Draft

fix: stop navigation forwarding service on cleanup on Android #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/java/com/google/android/react/navsdk/NavForwardingManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public static void startNavForwarding(

/** Unregisters the service receiving navigation updates */
public static void stopNavForwarding(
Navigator navigator, Context context, INavigationCallback navigationCallback) {
Navigator navigator, INavigationCallback navigationCallback) {
// Unregister the nav info receiving service.
boolean success = navigator.unregisterServiceForNavUpdates();
if (success) {
Expand Down
8 changes: 6 additions & 2 deletions android/src/main/java/com/google/android/react/navsdk/NavModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,14 @@ public void cleanup(final Promise promise) {
}

final Navigator navigator = mNavigator;
mNavigator = null;
mRoadSnappedLocationProvider = null;

UiThreadUtil.runOnUiThread(
() -> {
navigator.clearDestinations();
NavForwardingManager.stopNavForwarding(navigator, this);
navigator.stopGuidance();
navigator.clearDestinations();
navigator.getSimulator().unsetUserLocation();
promise.resolve(true);
});
Expand Down Expand Up @@ -415,7 +419,7 @@ public void setTurnByTurnLoggingEnabled(boolean isEnabled) {
if (isEnabled) {
NavForwardingManager.startNavForwarding(mNavigator, currentActivity, this);
} else {
NavForwardingManager.stopNavForwarding(mNavigator, currentActivity, this);
NavForwardingManager.stopNavForwarding(mNavigator, this);
}
}

Expand Down
Loading