Skip to content

fix: enable android turn by turn events on background #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illuminati1911 merged 2 commits into from
Jun 12, 2026
Merged

fix: enable android turn by turn events on background #613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
659bc30
fix: enable android turn by turn events on background
illuminati1911 Jun 12, 2026
ab05c37
fix: clean up background nav observer on android init failure
illuminati1911 Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions android/src/main/java/com/google/android/react/navsdk/NavModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import android.location.Location;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.lifecycle.LifecycleOwner;
import androidx.lifecycle.Observer;
import com.facebook.react.bridge.Arguments;
import com.facebook.react.bridge.LifecycleEventListener;
Expand Down Expand Up @@ -286,17 +285,15 @@ public void initializeNavigationSession(
// Initialize the navigation API
initializeNavigationApi();

// Observe live data for nav info updates.
// Observe nav info independently from the current Activity lifecycle.
// Background turn-by-turn updates continue to arrive in NavInfoReceivingService even when the
// app is paused, so using an Activity-bound LiveData observer drops them while backgrounded.
// Remove any existing observer first to prevent duplicates after cleanup+reinit cycles.
UiThreadUtil.runOnUiThread(
() -> {
removeNavInfoObserver();
mNavInfoObserver = this::showNavInfo;
final Activity currentActivity = getReactApplicationContext().getCurrentActivity();
if (currentActivity != null) {
NavInfoReceivingService.getNavInfoLiveData()
.observe((LifecycleOwner) currentActivity, mNavInfoObserver);
}
NavInfoReceivingService.getNavInfoLiveData().observeForever(mNavInfoObserver);
});
}

Expand Down Expand Up @@ -354,6 +351,7 @@ private void onNavigationInitError(int errorCode) {
}
pendingInitPromise.reject(errorCodeStr, errorMessage);
pendingInitPromise = null;
UiThreadUtil.runOnUiThread(this::removeNavInfoObserver);
}
}

Expand Down Expand Up @@ -1093,5 +1091,7 @@ public void onHostResume() {
public void onHostPause() {}

@Override
public void onHostDestroy() {}
public void onHostDestroy() {
UiThreadUtil.runOnUiThread(this::removeNavInfoObserver);
}
}
Loading