Skip to content

Commit 43fa174

Browse files
LiedtkeV8-internal LUCI CQ
authored andcommitted
[js] Also generate empty strings
Bug: 495679730 Change-Id: I45c1af939f3e1a81fc1c3a2649652e25c644cc82 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/9137477 Reviewed-by: Darius Mercadier <dmercadier@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com>
1 parent 506d593 commit 43fa174

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

Sources/Fuzzilli/Base/ProgramBuilder.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,10 @@ public class ProgramBuilder {
377377
}, {
378378
String(self.randomInt())
379379
}, {
380-
String.random(ofLength: Int.random(in: 1...5))
380+
// Prefer smaller strings both for readability as well as for small string optimizations
381+
// (e.g. optimizations for single character strings) but also generate larger strings
382+
// to hit cons string ("rope" / concatenated string) cases.
383+
String.random(ofLength: Int.random(in: Bool.random() ? 0...5 : 0...33))
381384
})
382385
}
383386

Sources/Fuzzilli/Environment/JavaScriptEnvironment.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public class JavaScriptEnvironment: ComponentBase {
5959
public let interestingFloats = [-Double.infinity, -Double.greatestFiniteMagnitude, -1e-15, -1e12, -1e9, -1e6, -1e3, -5.0, -4.0, -3.0, -2.0, -1.0, -Double.ulpOfOne, -Double.leastNormalMagnitude, -0.0, 0.0, Double.leastNormalMagnitude, Double.ulpOfOne, 1.0, 2.0, 3.0, 4.0, 5.0, 1e3, 1e6, 1e9, 1e12, 1e-15, Double.greatestFiniteMagnitude, Double.infinity, Double.nan]
6060

6161
// TODO more?
62-
public let interestingStrings = jsTypeNames
62+
public let interestingStrings = jsTypeNames + [""]
6363

6464
// Copied from
6565
// https://cs.chromium.org/chromium/src/testing/libfuzzer/fuzzers/dicts/regexp.dict

0 commit comments

Comments
 (0)