Skip to content

Commit 62fcae9

Browse files
Dominik KlembaV8-internal LUCI CQ
authored andcommitted
[tests] Increase failure threshold for Wasm execution test
Changes the failure rate for LiveTests.testWasmCodeGenerationAndCompilationAndExecution from 25% to 35%. This threshold should be reduced again once ref.cast is properly handled. Change-Id: I92938e5c58ce6171627cc003a13d5344c9cafe70 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/9087656 Commit-Queue: Matthias Liedtke <mliedtke@google.com> Auto-Submit: Dominik Klemba <tacet@google.com> Commit-Queue: Dominik Klemba <tacet@google.com> Reviewed-by: Matthias Liedtke <mliedtke@google.com>
1 parent 8171075 commit 62fcae9

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Tests/FuzzilliTests/LiveTests.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,9 @@ class LiveTests: XCTestCase {
158158
}
159159
}
160160

161-
// We expect a maximum of 25% of Wasm execution attempts to fail.
162-
checkFailureRate(testResults: results, maxFailureRate: 0.25)
161+
// TODO(mliedtke): Figure out how to handle ref.cast and lower it.
162+
// We expect a maximum of 35% of Wasm execution attempts to fail.
163+
checkFailureRate(testResults: results, maxFailureRate: 0.35)
163164
}
164165

165166
// The closure can use the ProgramBuilder to emit a program of a specific

0 commit comments

Comments
 (0)