style: manual fixes

jpoehnelt · jpoehnelt · commit 520db0a114aa · 2025-11-24T17:08:06.000-07:00
diff --git a/ai/autosummarize/gemini.js b/ai/autosummarize/gemini.js
@@ -37,14 +37,16 @@ const SERVICE_ACCOUNT_KEY = scriptPropertyWithDefault("service_account_key");
  *
  * @param {string} prompt The prompt to senb to Vertex AI API.
  * @param {string} options.temperature The temperature setting set by user.
- * @param {string} options.tokens The number of tokens to limit to the prompt.
+ * @param {string} options.maxOutputTokens The number of tokens to limit to the prompt.
  */
 function getAiSummary(parts, options = {}) {
-	options = Object.assign(
-		{},
-		{ temperature: 0.1, tokens: 8192 },
-		options ?? {},
-	);
+	const defaultOptions = {
+		temperature: 0.1,
+		maxOutputTokens: 8192,
+		topK: 1,
+		topP: 1,
+		stopSequences: [],
+	};
 	const request = {
 		contents: [
 			{
@@ -53,11 +55,8 @@ function getAiSummary(parts, options = {}) {
 			},
 		],
 		generationConfig: {
-			temperature: options.temperature,
-			topK: 1,
-			topP: 1,
-			maxOutputTokens: options.tokens,
-			stopSequences: [],
+			...defaultOptions,
+			...options,
 		},
 	};
 
diff --git a/ai/autosummarize/main.js b/ai/autosummarize/main.js
@@ -59,13 +59,13 @@ function removeAllSummaries() {
 	const spreadsheet = SpreadsheetApp.getActiveSpreadsheet();
 	const allSheets = spreadsheet.getSheets();
 
-	allSheets.forEach((sheet) => {
+	for (const sheet of allSheets) {
 		const sheetName = sheet.getName();
 		// Check if the sheet name starts with "AutoSummarize AI"
 		if (sheetName.startsWith("AutoSummarize AI")) {
 			spreadsheet.deleteSheet(sheet);
 		}
-	});
+	}
 }
 
 /**
diff --git a/ai/custom-func-ai-agent/Code.js b/ai/custom-func-ai-agent/Code.js
@@ -14,6 +14,12 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+DEFAULT_OUTPUT_FORMAT =
+	"Summarize it. Only keep the verdict result and main arguments. " +
+	"Do not reiterate the fact being checked. Remove all markdown. " +
+	"State the verdit result in a first paragraph in a few words and " +
+	"the rest of the summary in a second paragraph.";
+
 /**
  * Passes a statement to fact-check and, optionally, output formatting instructions.
  *
@@ -25,14 +31,7 @@ limitations under the License.
  * @return The generated and formatted verdict
  * @customfunction
  */
-function FACT_CHECK(statement, outputFormat) {
-	if (!outputFormat || outputFormat === "") {
-		outputFormat =
-			"Summarize it. Only keep the verdict result and main arguments. " +
-			"Do not reiterate the fact being checked. Remove all markdown. " +
-			"State the verdit result in a first paragraph in a few words and the rest of the summary in a second paragraph.";
-	}
-
+function FACT_CHECK(statement, outputFormat = DEFAULT_OUTPUT_FORMAT) {
 	return requestOutputFormatting(
 		`Here is a fact checking result: ${requestLlmAuditorAdkAiAgent(statement)}.\n\n${outputFormat}`,
 	);
diff --git a/ai/custom-func-ai-studio/Code.js b/ai/custom-func-ai-studio/Code.js
@@ -23,6 +23,5 @@ limitations under the License.
  * @customfunction
  */
 function gemini(range, prompt) {
-	prompt = `For the range of cells ${range}, ${prompt}`;
-	return getAiSummary(prompt);
+	return getAiSummary(`For the range of cells ${range}, ${prompt}`);
 }
diff --git a/ai/custom_func_vertex/Code.js b/ai/custom_func_vertex/Code.js
@@ -7,6 +7,7 @@
  * @customfunction
  */
 function gemini(range, prompt) {
-	prompt = `For the table of data: ${range}, Answer the following: ${prompt}. Do not use formatting. Remove all markdown.`;
-	return getAiSummary(prompt);
+	return getAiSummary(
+		`For the table of data: ${range} Answer the following: ${prompt}. Do not use formatting. Remove all markdown.`,
+	);
 }
diff --git a/ai/drive-rename/ui.js b/ai/drive-rename/ui.js
@@ -84,13 +84,13 @@ function buildSelectionPage(e) {
 
 		// Create an object of items
 		const items = [];
-		aiResponse.names.forEach((name) => {
+		for (const name of aiResponse.names) {
 			items.push({
 				text: name,
 				value: name,
 				selected: false,
 			});
-		});
+		}
 
 		// Set first item as selected
 		items[0].selected = true;
diff --git a/ai/standup-chat-app/db.js b/ai/standup-chat-app/db.js
@@ -64,7 +64,7 @@ class DB {
 	 */
 	get last() {
 		const lastRow = this.sheet.getLastRow();
-		if (lastRow === 0) return;
+		if (lastRow === 0) return undefined;
 		return JSON.parse(this.sheet.getSheetValues(lastRow, 1, 1, 2)[0][1]);
 	}
 
diff --git a/solutions/add-on/share-macro/UI.js b/solutions/add-on/share-macro/UI.js
@@ -257,10 +257,11 @@ function onClickFunction_(e) {
 			.setOnClickAction(CardService.newAction().setFunctionName("onHomepage")),
 	);
 
-	return (builder = CardService.newCardBuilder()
+	const builder = CardService.newCardBuilder()
 		.setHeader(cardHeader)
 		.addSection(sectionBody1)
 		.addSection(sectionBody2)
-		.setFixedFooter(cardFooter)
-		.build());
+		.setFixedFooter(cardFooter);
+
+	return builder.build();
 }
diff --git a/solutions/automations/aggregate-document-content/Code.js b/solutions/automations/aggregate-document-content/Code.js
@@ -129,7 +129,12 @@ function getContent(body) {
 	let searchResult = null;
 
 	// Gets and loops through all paragraphs that match the style of APP_STYLE.
-	while ((searchResult = body.findElement(searchType, searchResult))) {
+	while (true) {
+		searchResult = body.findElement(searchType, searchResult);
+		if (!searchResult) {
+			break;
+		}
+
 		const par = searchResult.getElement().asParagraph();
 		if (par.getHeading() === searchHeading) {
 			// If heading style matches, searches for text string (case insensitive).
diff --git a/solutions/automations/calendar-timesheet/Code.js b/solutions/automations/calendar-timesheet/Code.js
@@ -71,15 +71,15 @@ const getSettings = () => {
 
 	// find any calendars that were removed
 	const unavailebleCalendars = [];
-	savedCalendarSettings.forEach((savedCalendarSetting) => {
+	for (const savedCalendarSetting of savedCalendarSettings) {
 		if (
 			!availableCalendars.find(
 				(availableCalendar) => availableCalendar.id === savedCalendarSetting.id,
 			)
 		) {
 			unavailebleCalendars.push(savedCalendarSetting);
 		}
-	});
+	}
 
 	// map the current settings to the available calendars
 	const calendarSettings = availableCalendars.map((availableCalendar) => {
diff --git a/solutions/automations/equipment-requests/Code.js b/solutions/automations/equipment-requests/Code.js
@@ -71,11 +71,11 @@ function setup_() {
 	form.addListItem().setTitle("Monitor").setChoiceValues(AVAILABLE_MONITORS);
 
 	// Hide the raw form responses.
-	ss.getSheets().forEach((sheet) => {
+	for (const sheet of ss.getSheets()) {
 		if (sheet.getFormUrl() === ss.getFormUrl()) {
 			sheet.hideSheet();
 		}
-	});
+	}
 	// Start workflow on each form submit
 	ScriptApp.newTrigger("onFormSubmit_").forForm(form).onFormSubmit().create();
 	// Archive completed items every 5m.
@@ -93,9 +93,9 @@ function cleanup_() {
 	if (!formUrl) {
 		return;
 	}
-	ScriptApp.getProjectTriggers().forEach((trigger) => {
+	for (const trigger of ScriptApp.getProjectTriggers()) {
 		ScriptApp.deleteTrigger(trigger);
-	});
+	}
 	FormApp.openByUrl(formUrl).deleteAllResponses().setAcceptingResponses(false);
 }
 
diff --git a/solutions/automations/event-session-signup/Code.js b/solutions/automations/event-session-signup/Code.js
@@ -87,11 +87,11 @@ function setUpCalendar_(values, range) {
  * @param {Date} time A Date object from which to extract the time.
  * @return {Date} A Date object representing the combined date and time.
  */
-function joinDateAndTime_(date, time) {
-	date = new Date(date);
-	date.setHours(time.getHours());
-	date.setMinutes(time.getMinutes());
-	return date;
+function joinDateAndTime_(date_, time) {
+	const processedDate = new Date(date_);
+	processedDate.setHours(time.getHours());
+	processedDate.setMinutes(time.getMinutes());
+	return processedDate;
 }
 
 /**
@@ -124,15 +124,15 @@ function setUpForm_(ss, values) {
 	form.setDestination(FormApp.DestinationType.SPREADSHEET, ss.getId());
 	form.addTextItem().setTitle("Name").setRequired(true);
 	form.addTextItem().setTitle("Email").setRequired(true);
-	Object.keys(schedule).forEach((day) => {
-		const header = form.addSectionHeaderItem().setTitle(`Sessions for ${day}`);
-		Object.keys(schedule[day]).forEach((time) => {
-			const item = form
+	for (const day of Object.keys(schedule)) {
+		form.addSectionHeaderItem().setTitle(`Sessions for ${day}`);
+		for (const time of Object.keys(schedule[day])) {
+			form
 				.addMultipleChoiceItem()
 				.setTitle(`${time} ${day}`)
 				.setChoiceValues(schedule[day][time]);
-		});
-	});
+		}
+	}
 }
 
 /**
diff --git a/solutions/automations/generate-pdfs/Code.js b/solutions/automations/generate-pdfs/Code.js
@@ -60,7 +60,7 @@ function processDocuments() {
 	const invoices = [];
 
 	// Iterates for each customer calling createInvoiceForCustomer routine.
-	customers.forEach((customer) => {
+	for (const customer of customers) {
 		ss.toast(`Creating Invoice for ${customer.customer_name}`, APP_TITLE, 1);
 		const invoice = createInvoiceForCustomer(
 			customer,
@@ -70,7 +70,7 @@ function processDocuments() {
 			ss.getId(),
 		);
 		invoices.push(invoice);
-	});
+	}
 	// Writes invoices data to the sheet.
 	invoicesSheet
 		.getRange(2, 1, invoices.length, invoices[0].length)
@@ -103,7 +103,7 @@ function createInvoiceForCustomer(
 
 	const lineItems = [];
 	let totalAmount = 0;
-	customerTransactions.forEach((lineItem) => {
+	for (const lineItem of customerTransactions) {
 		const lineItemProduct = products.filter(
 			(product) => product.sku_name === lineItem.sku,
 		)[0];
@@ -119,7 +119,7 @@ function createInvoiceForCustomer(
 			amount,
 		]);
 		totalAmount += Number.parseFloat(amount);
-	});
+	}
 
 	// Generates a random invoice number. You can replace with your own document ID method.
 	const invoiceNumber = Math.floor(100000 + Math.random() * 900000);
@@ -173,9 +173,9 @@ function clearTemplateSheet() {
 	const rngClear = templateSheet
 		.getRangeList(["B10:B11", "F10", "F12", "F14"])
 		.getRanges();
-	rngClear.forEach((cell) => {
+	for (const cell of rngClear) {
 		cell.clearContent();
-	});
+	}
 	// This sample only accounts for six rows of data 'B18:G24'. You can extend or make dynamic as necessary.
 	templateSheet.getRange(18, 2, 7, 6).clearContent();
 }
diff --git a/solutions/automations/import-csv-sheets/Code.js b/solutions/automations/import-csv-sheets/Code.js
@@ -89,18 +89,15 @@ function updateApplicationSheet() {
 	// Iterates through each CSV file.
 	while (cvsFiles.hasNext()) {
 		const csvFile = cvsFiles.next();
-		let isSuccess;
-
-		// Appends the unprocessed CSV data into the Google Sheets spreadsheet.
-		isSuccess = processCsv_(objSpreadSheet, csvFile);
+		const isSuccess = processCsv_(objSpreadSheet, csvFile);
 
 		if (isSuccess) {
 			// Moves the processed file to the processed folder to prevent future duplicate data imports.
 			csvFile.moveTo(folderProcessed);
 			// Logs the successfully processed file to the filesProcessed array.
 			filesProcessed.push(csvFile.getName());
 			console.log(`Successfully processed: ${csvFile.getName()}`);
-		} else if (!isSuccess) {
+		} else {
 			// Doesn't move the unsuccesfully processed file so that it can be corrected and reprocessed later.
 			// Logs the unsuccessfully processed file to the filesNotProcessed array.
 			filesNotProcessed.push(csvFile.getName());
diff --git a/solutions/automations/mail-merge/Code.js b/solutions/automations/mail-merge/Code.js
@@ -43,22 +43,23 @@ function onOpen() {
  */
 function sendEmails(subjectLine, sheet = SpreadsheetApp.getActiveSheet()) {
 	// option to skip browser prompt if you want to use this code in other projects
-	if (!subjectLine) {
-		subjectLine = Browser.inputBox(
+	let processedSubjectLine = subjectLine;
+	if (!processedSubjectLine) {
+		processedSubjectLine = Browser.inputBox(
 			"Mail Merge",
 			"Type or copy/paste the subject line of the Gmail " +
 				"draft message you would like to mail merge with:",
 			Browser.Buttons.OK_CANCEL,
 		);
 
-		if (subjectLine === "cancel" || subjectLine === "") {
+		if (processedSubjectLine === "cancel" || processedSubjectLine === "") {
 			// If no subject line, finishes up
 			return;
 		}
 	}
 
 	// Gets the draft Gmail message to use as a template
-	const emailTemplate = getGmailTemplateFromDrafts_(subjectLine);
+	const emailTemplate = getGmailTemplateFromDrafts_(processedSubjectLine);
 
 	// Gets the data from the passed sheet
 	const dataRange = sheet.getDataRange();
@@ -78,7 +79,10 @@ function sendEmails(subjectLine, sheet = SpreadsheetApp.getActiveSheet()) {
 	// See https://stackoverflow.com/a/22917499/1027723
 	// For a pretty version, see https://mashe.hawksey.info/?p=17869/#comment-184945
 	const obj = data.map((r) =>
-		heads.reduce((o, k, i) => ((o[k] = r[i] || ""), o), {}),
+		heads.reduce((o, k, i) => {
+			o[k] = r[i] || "";
+			return o;
+		}, {}),
 	);
 
 	// Creates an array to record sent emails
@@ -147,21 +151,20 @@ function sendEmails(subjectLine, sheet = SpreadsheetApp.getActiveSheet()) {
 
 			// Creates an inline image object with the image name as key
 			// (can't rely on image index as array based on insert order)
-			const img_obj = allInlineImages.reduce(
-				(obj, i) => ((obj[i.getName()] = i), obj),
-				{},
-			);
+			const img_obj = allInlineImages.reduce((obj, i) => {
+				obj[i.getName()] = i;
+				return obj;
+			}, {});
 
 			//Regexp searches for all img string positions with cid
 			const imgexp = /<img.*?src="cid:(.*?)".*?alt="(.*?)"[^\>]+>/g;
 			const matches = [...htmlBody.matchAll(imgexp)];
 
 			//Initiates the allInlineImages object
 			const inlineImagesObj = {};
-			// built an inlineImagesObj from inline image matches
-			matches.forEach(
-				(match) => (inlineImagesObj[match[1]] = img_obj[match[2]]),
-			);
+			for (const match of matches) {
+				inlineImagesObj[match[1]] = img_obj[match[2]];
+			}
 
 			return {
 				message: {
diff --git a/solutions/automations/upload-files/Code.js b/solutions/automations/upload-files/Code.js
@@ -71,7 +71,7 @@ function onFormSubmit(e) {
 					itemResponse.getItem().getType().toString() === "FILE_UPLOAD",
 			)
 			.map((itemResponse) => itemResponse.getResponse())
-			.reduce((a, b) => [...a, ...b], []);
+			.reduce((a, b) => a.concat(b), []);
 
 		// Moves the files to the destination folder.
 		if (fileUploads.length > 0) {
diff --git a/solutions/automations/vacation-calendar/Code.js b/solutions/automations/vacation-calendar/Code.js

Original file line number	Diff line number	Diff line change
`@@ -59,13 +59,13 @@ function removeAllSummaries() {`
`59`	`59`	`const spreadsheet = SpreadsheetApp.getActiveSpreadsheet();`
`60`	`60`	`const allSheets = spreadsheet.getSheets();`
`61`	`61`
`62`		`- allSheets.forEach((sheet) => {`
	`62`	`+ for (const sheet of allSheets) {`
`63`	`63`	`const sheetName = sheet.getName();`
`64`	`64`	`// Check if the sheet name starts with "AutoSummarize AI"`
`65`	`65`	`if (sheetName.startsWith("AutoSummarize AI")) {`
`66`	`66`	`spreadsheet.deleteSheet(sheet);`
`67`	`67`	`}`
`68`		`- });`
	`68`	`+ }`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,5 @@ limitations under the License.`
`23`	`23`	`* @customfunction`
`24`	`24`	`*/`
`25`	`25`	`function gemini(range, prompt) {`
`26`		- prompt = `For the range of cells ${range}, ${prompt}`;
`27`		`- return getAiSummary(prompt);`
	`26`	+ return getAiSummary(`For the range of cells ${range}, ${prompt}`);
`28`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ class DB {`
`64`	`64`	`*/`
`65`	`65`	`get last() {`
`66`	`66`	`const lastRow = this.sheet.getLastRow();`
`67`		`- if (lastRow === 0) return;`
	`67`	`+ if (lastRow === 0) return undefined;`
`68`	`68`	`return JSON.parse(this.sheet.getSheetValues(lastRow, 1, 1, 2)[0][1]);`
`69`	`69`	`}`
`70`	`70`