Commit 7edb25a
committed
Clean up CI Workflow (Node Version Warnings + Type Check Fail)
- setup-node@v4 uses Node v24 by default, triggering warnings by
declaring v22. Developer and CI tooling is now unified through
.nvmrc, CI.yml, and package.json (Current Astro version requires
a minimum of 22.12.0 which is documented in package.json;
node 24 is the most recent LTS which, used in CI and local dev)
- Type checking in Astro assumes that artifacts in .astro/ are
available; references in source ts files are connected to
these artifacts so tsc throws errors without them.
So, `astro sync` must be run before typechecking
in CI which creates the artifacts in `.astro/`. For convenience,
`astro sync` is added to the `typecheck` npm script so it works
in dev environments and CI.1 parent 23b60b0 commit 7edb25a
3 files changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
21 | 25 | | |
22 | 26 | | |
23 | 27 | | |
| |||
0 commit comments