fix(bottomsheet): fix an issue that results in a collapsed bottomshee…#2640
Open
jspizziri wants to merge 1 commit intogorhom:masterfrom
Open
fix(bottomsheet): fix an issue that results in a collapsed bottomshee…#2640jspizziri wants to merge 1 commit intogorhom:masterfrom
jspizziri wants to merge 1 commit intogorhom:masterfrom
Conversation
…t from being visible in chrome a collapsed bottom sheet will be visible under certain circumstances when the user is zoomed out due to in incorrectly calculated closed position. this issue is more prominent during window resizes while zoomed out. fix gorhom#2639
TwanLuttik
added a commit
to TwanLuttik/react-native-bottom-sheet
that referenced
this pull request
Apr 8, 2026
- Fix gorhom#2640: INITIAL_POSITION now uses Math.max(SCREEN_HEIGHT, WINDOW_HEIGHT) to handle web viewport resizing - Fix gorhom#2533: Account for scrollableContentOffsetY when calculating destinationPoint to fix scroll jumpy issue; change map to forEach for biome compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t from being visible
in chrome a collapsed bottom sheet will be visible under certain circumstances when the user is zoomed out due to in incorrectly calculated closed position. this issue is more prominent during window resizes while zoomed out.
fix #2639
Please provide enough information so that others can review your pull request:
Motivation
This issue solves #2639