Skip to content

fix: make dismiss() idempotent on a never-presented modal (#2669) #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ycmjason wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: make dismiss() idempotent on a never-presented modal (#2669) #2670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40e1c41
fix: make dismiss() idempotent on a never-presented modal (#2669)
ycmjason May 12, 2026
272b495
docs: clarify handleDismiss early-exit comment
ycmjason May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/components/bottomSheetModal/BottomSheetModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,13 +273,16 @@ function BottomSheetModalComponent<T = never>(
}

/**
* if the modal position is already in a closed position,
* then we unmount the node and early exit.
* if the modal has no inner sheet to animate (never presented,
* already closed, or minimized), then we unmount the node and
* early exit.
*/
if (
[MODAL_STATUS.CLOSED, MODAL_STATUS.MINIMIZED].includes(
statusRef.current
) ||
[
MODAL_STATUS.INITIAL,
MODAL_STATUS.CLOSED,
MODAL_STATUS.MINIMIZED,
].includes(statusRef.current) ||
(statusRef.current === MODAL_STATUS.DISMISSING &&
currentIndexRef.current === -1)
) {
Expand Down